Bug 2416680
| Summary: | Review Request: hana - Application to capture thumbnails from video files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> | ||||
| Component: | Package Review | Assignee: | Yaakov Selkowitz <yselkowi> | ||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | package-review, yselkowi | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | yselkowi:
fedora-review?
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://apps.kde.org/hana/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Steve Cossette
2025-11-23 21:18:36 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9830904 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416680-hana/fedora-rawhide-x86_64/09830904-hana/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. QML module dependencies are missing. Spec URL: https://farchord.fedorapeople.org/reviews/hana/hana.spec SRPM URL: https://farchord.fedorapeople.org/reviews/hana/hana-1.0.0-1.fc43.src.rpm Added qml requirements Created attachment 2115980 [details]
The .spec file difference from Copr build 9830904 to 9831168
Copr build: https://copr.fedorainfracloud.org/coprs/build/9831168 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416680-hana/fedora-rawhide-x86_64/09831168-hana/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. `BuildRequires: cmake(VulkanHeaders)` shouldn't be necessary -- there is no direct reference to anything vulkan in this package -- but I see there is a warning without it. It seems some other qt6-*-devel package needs to Requires it instead. It's okay to leave the BuildRequires for now, but with a comment explaining why it's necessary and a PR in the correct package to fix it. The `%find_lang` call should be in `%install`, not '%check`. |