Bug 2416903

Summary: Review Request: vst3sdk - VST 3 Plug-In SDK
Product: [Fedora] Fedora Reporter: Jerry James <loganjerry>
Component: Package ReviewAssignee: Benson Muite <benson_muite>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: benson_muite, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: benson_muite: fedora-review+
Hardware: All   
OS: Linux   
URL: https://steinbergmedia.github.io/vst3_doc/vstsdk/
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-02-13 01:28:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jerry James 2025-11-24 23:57:12 UTC 
Spec URL: https://jjames.fedorapeople.org/vst3sdk/vst3sdk.spec
SRPM URL: https://jjames.fedorapeople.org/vst3sdk/vst3sdk-3.8.0-1.fc44.src.rpm
Fedora Account System Username: jjames
Description: A VST® plug-in is an audio processing component that is utilized within a host application.  This host application provides the audio or/and event streams that are processed by the plug-in's code.  Generally speaking, a VST plug-in can take a stream of audio data, apply a process to the audio, and return the result to the host application.  A VST plug-in performs its process normally using the processor of the computer.  The audio stream is broken down into a series of blocks.  The host supplies the blocks in sequence.  The host and its current environment control the block-size.  The VST plug-in maintains the status of all its own parameters relating to the running process: The host does not maintain any information about what the plug-in did with the last block of data it processed.

From the host application's point of view, a VST plug-in is a black box with an arbitrary number of inputs, outputs (Event (MIDI) or Audio), and associated parameters.  The host needs no implicit knowledge of the plug-in's process to be able to use it.  The plug-in process can use whatever parameters it wishes, internally to the process, but depending on the capabilities of the host, it can allow the changes to user parameters to be automated by the host.

VST 3 is a general rework of the long-serving VST plug-in interface.  It is not compatible with the older VST versions, but it includes some new features and possibilities.  We have redesigned the API to make it not only far easier and more reliable for developers to work with, but have also provided completely new possibilities for plug-ins.

VST is a registered trademark of Steinberg Media Technologies GmbH.

I am willing to swap reviews.
Comment 1 Fedora Review Service 2025-11-25 00:06:59 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9834519
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2416903-vst3sdk/fedora-rawhide-x86_64/09834519-vst3sdk/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Jerry James 2025-12-26 14:07:56 UTC 
One month has gone by since you assigned this review to yourself, Benson.  Per https://docs.fedoraproject.org/en-US/fesco/Package_review_policy/#reviewer_not_responding, I am noting that this review is stalled.  Please respond in the next week.
Comment 3 Benson Muite 2025-12-26 15:18:10 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License", "BSD 3-Clause License", "*No copyright* The Unlicense",
     "zlib License", "*No copyright* Apache License and/or Creative Commons
     Attribution-ShareAlike 4.0 and/or SIL Open Font License 1.1 and/or
     zlib License", "MIT License and/or The Unlicense". 802 files have
     unknown license. Detailed output of licensecheck in
     /home/fedora-packaging/reviews/vst3sdk/2416903-
     vst3sdk/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 374970 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vst3sdk-
     hosting , vst3sdk-common , vst3sdk-tools
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: vst3sdk-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-hosting-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-common-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-devel-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-tools-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-3.8.0-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpr1kj0btu')]
checks: 32, packages: 6

vst3sdk-common.x86_64: W: package-with-huge-docs 61%
vst3sdk.x86_64: W: no-documentation
vst3sdk-devel.x86_64: W: no-documentation
vst3sdk-hosting.x86_64: W: no-documentation
vst3sdk.spec: W: no-%check-section
 6 packages and 0 specfiles checked; 0 errors, 5 warnings, 39 filtered, 0 badness; has taken 2.5 s 




Rpmlint (debuginfo)
-------------------
Checking: vst3sdk-tools-debuginfo-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-hosting-debuginfo-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-debuginfo-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-common-debuginfo-3.8.0-1.fc44.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpszg4ttg3')]
checks: 32, packages: 4

 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 30 filtered, 0 badness; has taken 0.9 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 9

vst3sdk-common.x86_64: W: package-with-huge-docs 61%
vst3sdk.x86_64: W: no-documentation
vst3sdk-devel.x86_64: W: no-documentation
vst3sdk-hosting.x86_64: W: no-documentation
 9 packages and 0 specfiles checked; 0 errors, 4 warnings, 70 filtered, 0 badness; has taken 2.5 s 



Source checksums
----------------
https://github.com/steinbergmedia/vst3sdk/archive/v3.8.0_build_66/vst3sdk-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : d93c12077d848977d4d397c8ab6721c4b4966223a7707bfe6519aa419c396af4
  CHECKSUM(SHA256) upstream package : d93c12077d848977d4d397c8ab6721c4b4966223a7707bfe6519aa419c396af4
https://github.com/steinbergmedia/vst3_base/archive/v3.8.0_build_66/vst3_base-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : 001ef3dccf89505ee624766c8140c6c845fbd214460e02ea16145db29f1e2ed6
  CHECKSUM(SHA256) upstream package : 001ef3dccf89505ee624766c8140c6c845fbd214460e02ea16145db29f1e2ed6
https://github.com/steinbergmedia/vst3_cmake/archive/v3.8.0_build_66/vst3_cmake-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : 7e252775d662f13f5ecf7671e44db947f793767926d87b3d482391e9a76406b4
  CHECKSUM(SHA256) upstream package : 7e252775d662f13f5ecf7671e44db947f793767926d87b3d482391e9a76406b4
https://github.com/steinbergmedia/vst3_pluginterfaces/archive/v3.8.0_build_66/vst3_pluginterfaces-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : c922f0a35f2c093dfcb24ccd95282e70d00cc2de42fc0c8ac1577398ffe7b6d4
  CHECKSUM(SHA256) upstream package : c922f0a35f2c093dfcb24ccd95282e70d00cc2de42fc0c8ac1577398ffe7b6d4
https://github.com/steinbergmedia/vst3_public_sdk/archive/v3.8.0_build_66/vst3_public_sdk-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : 83b64e6666a54a35a2292a73ef35048b6d0dadd5e50a22cb437ac4cfb69ba81f
  CHECKSUM(SHA256) upstream package : 83b64e6666a54a35a2292a73ef35048b6d0dadd5e50a22cb437ac4cfb69ba81f


Requires
--------
vst3sdk (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libvst3sdk_common.so.0()(64bit)
    rtld(GNU_HASH)
    vst3sdk-common(x86-64)

vst3sdk-hosting (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libvst3sdk_common.so.0()(64bit)
    rtld(GNU_HASH)
    vst3sdk-common(x86-64)

vst3sdk-common (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

vst3sdk-devel (rpmlib, GLIBC filtered):
    libvst3sdk.so.0()(64bit)
    libvst3sdk_common.so.0()(64bit)
    libvst3sdk_hosting.so.0()(64bit)
    vst3sdk(x86-64)
    vst3sdk-common(x86-64)
    vst3sdk-hosting(x86-64)

vst3sdk-tools (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libvst3sdk_common.so.0()(64bit)
    libvst3sdk_hosting.so.0()(64bit)
    rtld(GNU_HASH)
    vst3sdk-hosting(x86-64)



Provides
--------
vst3sdk:
    libvst3sdk.so.0()(64bit)
    vst3sdk
    vst3sdk(x86-64)

vst3sdk-hosting:
    libvst3sdk_hosting.so.0()(64bit)
    vst3sdk-hosting
    vst3sdk-hosting(x86-64)

vst3sdk-common:
    libvst3sdk_common.so.0()(64bit)
    vst3sdk-common
    vst3sdk-common(x86-64)

vst3sdk-devel:
    vst3sdk-devel
    vst3sdk-devel(x86-64)

vst3sdk-tools:
    vst3sdk-tools
    vst3sdk-tools(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2416903
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Python, R, fonts, SugarActivity, Ocaml, Haskell, PHP, Java, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=140414283
b) Can files with other license be removed prior to the build step? In particular
https://github.com/steinbergmedia/vst3_public_sdk/tree/a3911a4615dabbfdfd9d181ee26b05c70c289a95/samples/vst/dataexchange/source/3rdparty
c) Is it possible to upstream patch with option to create a shared library?
Comment 4 Jerry James 2025-12-29 20:29:56 UTC 
Thank you for the review.  I have updated the spec file to remove the contents of public.sdk/samples/vst in %prep.

Upstream does not accept pull requests, unfortunately, due to copyright concerns.  See https://github.com/steinbergmedia/vst3sdk/issues/140 for another person's attempt to make changes to the cmake files.  I think that upstream intentionally builds static libraries only, as the documentation suggests they expect this code to be used as a copylib; i.e., that developers will copy the code into their projects.

The spec file and srpm URLs are the same as before.
Comment 5 Jerry James 2026-01-29 20:36:41 UTC 
Another month has gone by.  I am noting that this review is stalled, again.  Please respond in the next week.
Comment 6 Benson Muite 2026-01-30 05:35:37 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License", "BSD 3-Clause License", "*No copyright* The Unlicense". 455
     files have unknown license. Detailed output of licensecheck in
     /home/fedora-packaging/reviews/vst3sdk/2416903-vst3sdk/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 374970 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vst3sdk-
     hosting , vst3sdk-common , vst3sdk-tools
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: vst3sdk-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-hosting-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-common-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-devel-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-tools-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-3.8.0-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp636g_oul')]
checks: 32, packages: 6

vst3sdk-common.x86_64: W: package-with-huge-docs 60%
vst3sdk.x86_64: W: no-documentation
vst3sdk-devel.x86_64: W: no-documentation
vst3sdk-hosting.x86_64: W: no-documentation
vst3sdk.spec: W: no-%check-section
 6 packages and 0 specfiles checked; 0 errors, 5 warnings, 38 filtered, 0 badness; has taken 2.0 s 




Rpmlint (debuginfo)
-------------------
Checking: vst3sdk-hosting-debuginfo-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-debuginfo-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-tools-debuginfo-3.8.0-1.fc44.x86_64.rpm
          vst3sdk-common-debuginfo-3.8.0-1.fc44.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpu4i5c1dh')]
checks: 32, packages: 4

 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 30 filtered, 0 badness; has taken 0.9 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 9

vst3sdk-common.x86_64: W: package-with-huge-docs 60%
vst3sdk-hosting.x86_64: W: no-documentation
vst3sdk-devel.x86_64: W: no-documentation
vst3sdk.x86_64: W: no-documentation
 9 packages and 0 specfiles checked; 0 errors, 4 warnings, 69 filtered, 0 badness; has taken 2.2 s 



Source checksums
----------------
https://github.com/steinbergmedia/vst3sdk/archive/v3.8.0_build_66/vst3sdk-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : d93c12077d848977d4d397c8ab6721c4b4966223a7707bfe6519aa419c396af4
  CHECKSUM(SHA256) upstream package : d93c12077d848977d4d397c8ab6721c4b4966223a7707bfe6519aa419c396af4
https://github.com/steinbergmedia/vst3_base/archive/v3.8.0_build_66/vst3_base-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : 001ef3dccf89505ee624766c8140c6c845fbd214460e02ea16145db29f1e2ed6
  CHECKSUM(SHA256) upstream package : 001ef3dccf89505ee624766c8140c6c845fbd214460e02ea16145db29f1e2ed6
https://github.com/steinbergmedia/vst3_cmake/archive/v3.8.0_build_66/vst3_cmake-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : 7e252775d662f13f5ecf7671e44db947f793767926d87b3d482391e9a76406b4
  CHECKSUM(SHA256) upstream package : 7e252775d662f13f5ecf7671e44db947f793767926d87b3d482391e9a76406b4
https://github.com/steinbergmedia/vst3_pluginterfaces/archive/v3.8.0_build_66/vst3_pluginterfaces-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : c922f0a35f2c093dfcb24ccd95282e70d00cc2de42fc0c8ac1577398ffe7b6d4
  CHECKSUM(SHA256) upstream package : c922f0a35f2c093dfcb24ccd95282e70d00cc2de42fc0c8ac1577398ffe7b6d4
https://github.com/steinbergmedia/vst3_public_sdk/archive/v3.8.0_build_66/vst3_public_sdk-3.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : 83b64e6666a54a35a2292a73ef35048b6d0dadd5e50a22cb437ac4cfb69ba81f
  CHECKSUM(SHA256) upstream package : 83b64e6666a54a35a2292a73ef35048b6d0dadd5e50a22cb437ac4cfb69ba81f


Requires
--------
vst3sdk (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libvst3sdk_common.so.0()(64bit)
    rtld(GNU_HASH)
    vst3sdk-common(x86-64)

vst3sdk-hosting (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libvst3sdk_common.so.0()(64bit)
    rtld(GNU_HASH)
    vst3sdk-common(x86-64)

vst3sdk-common (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

vst3sdk-devel (rpmlib, GLIBC filtered):
    libvst3sdk.so.0()(64bit)
    libvst3sdk_common.so.0()(64bit)
    libvst3sdk_hosting.so.0()(64bit)
    vst3sdk(x86-64)
    vst3sdk-common(x86-64)
    vst3sdk-hosting(x86-64)

vst3sdk-tools (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libvst3sdk_common.so.0()(64bit)
    libvst3sdk_hosting.so.0()(64bit)
    rtld(GNU_HASH)
    vst3sdk-hosting(x86-64)



Provides
--------
vst3sdk:
    libvst3sdk.so.0()(64bit)
    vst3sdk
    vst3sdk(x86-64)

vst3sdk-hosting:
    libvst3sdk_hosting.so.0()(64bit)
    vst3sdk-hosting
    vst3sdk-hosting(x86-64)

vst3sdk-common:
    libvst3sdk_common.so.0()(64bit)
    vst3sdk-common
    vst3sdk-common(x86-64)

vst3sdk-devel:
    vst3sdk-devel
    vst3sdk-devel(x86-64)

vst3sdk-tools:
    vst3sdk-tools
    vst3sdk-tools(x86-64)



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2416903
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: SugarActivity, Java, R, Haskell, PHP, fonts, Ocaml, Perl, Python
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Approved.
b) Review of:
https://bugzilla.redhat.com/show_bug.cgi?id=2430667
would be appreciated.
Comment 7 Jerry James 2026-02-10 23:28:18 UTC 
I'm sorry, now it is my turn to be slow. :-(  Somebody else already took bug 2430667, but I admit to curiosity about your interest in OCaml.

Thank you for the review!
Comment 8 Fedora Admin user for bugzilla script actions 2026-02-10 23:31:58 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/vst3sdk
Comment 9 Fedora Update System 2026-02-11 00:09:36 UTC 
FEDORA-2026-ba680ad5bb (vst3sdk-3.8.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-ba680ad5bb
Comment 10 Fedora Update System 2026-02-11 01:12:20 UTC 
FEDORA-2026-ba680ad5bb has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-ba680ad5bb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-ba680ad5bb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 11 Fedora Update System 2026-02-12 01:31:22 UTC 
FEDORA-2026-ba680ad5bb has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-ba680ad5bb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-ba680ad5bb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 12 Fedora Update System 2026-02-13 01:28:22 UTC 
FEDORA-2026-ba680ad5bb (musescore-4.6.5-33.fc43 and vst3sdk-3.8.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.