Bug 2417372

> URL:            https://metacpan.org/dist/Chemistry-Mol

Should be:

 URL: https://metacpan.org/pod/Math::VectorReal ?

The rest seems fine.

Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[?]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/perl5/vendor_perl/Math
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2997 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Rpmlint
-------
Checking: perl-Math-VectorReal-1.02-1.fc44.noarch.rpm
          perl-Math-VectorReal-1.02-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp48y4raf0')]
checks: 32, packages: 2

perl-Math-VectorReal.noarch: E: spelling-error ('MatrixReal', '%description -l en_US MatrixReal -> Matrix Real, Matrix-Real, Matricidal')
perl-Math-VectorReal.src: E: spelling-error ('MatrixReal', '%description -l en_US MatrixReal -> Matrix Real, Matrix-Real, Matricidal')
perl-Math-VectorReal.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/Math/matrix_test.pl 644 /usr/bin/perl
perl-Math-VectorReal.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/Math/synopsis.pl 644 /usr/bin/perl
perl-Math-VectorReal.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/Math/vector_test.pl 644 /usr/bin/perl
 2 packages and 0 specfiles checked; 5 errors, 0 warnings, 7 filtered, 5 badness; has taken 0.2 s 


Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

perl-Math-VectorReal.noarch: E: spelling-error ('MatrixReal', '%description -l en_US MatrixReal -> Matrix Real, Matrix-real, Maltreat')
perl-Math-VectorReal.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/Math/matrix_test.pl 644 /usr/bin/perl
perl-Math-VectorReal.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/Math/synopsis.pl 644 /usr/bin/perl
perl-Math-VectorReal.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/Math/vector_test.pl 644 /usr/bin/perl
 1 packages and 0 specfiles checked; 4 errors, 0 warnings, 3 filtered, 4 badness; has taken 0.1 s 

Source checksums
----------------
https://cpan.metacpan.org/authors/id/A/AN/ANTHONY/Math-VectorReal-1.02.tar.gz :
  CHECKSUM(SHA256) this package     : 8c959600865b09ea0d4d5567ad6bc9e0c81040f76bfb451cb27aeb0eb9cc548b
  CHECKSUM(SHA256) upstream package : 8c959600865b09ea0d4d5567ad6bc9e0c81040f76bfb451cb27aeb0eb9cc548b


Requires
--------
perl-Math-VectorReal (rpmlib, GLIBC filtered):
    perl(Carp)
    perl(Exporter)
    perl(overload)
    perl(strict)
    perl(vars)
    perl-libs

Provides
--------
perl-Math-VectorReal:
    perl(Math::MatrixReal)
    perl(Math::VectorReal)
    perl-Math-VectorReal

 Summary:
---------
 - Fix URL
 - Add %dir on /usr/share/perl5/vendor_perl/Math
 - Remove shebang or change to 0755 for 
 /usr/share/perl5/vendor_perl/Math/matrix_test.pl
 /usr/share/perl5/vendor_perl/Math/synopsis.pl
 /usr/share/perl5/vendor_perl/Math/vector_test.pl

Thanks for the review!

All fixed:

Spec URL: https://rathann.fedorapeople.org/review/perl-Math-VectorReal/perl-Math-VectorReal.spec
SRPM URL: https://rathann.fedorapeople.org/review/perl-Math-VectorReal/perl-Math-VectorReal-1.02-1.fc44.src.rpm

* Fri Nov 28 2025 Dominik 'Rathann' Mierzejewski <dominik> - 1.02-2
- address issues found in review
- own perl_vendorlib/Math dir
- fix URL
- drop test scripts from final package

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9847196
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2417372-perl-math-vectorreal/fedora-rawhide-x86_64/09847196-perl-Math-VectorReal/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks good!

 package is APPROVED

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Math-VectorReal

FEDORA-2025-f709d5a926 (perl-Math-VectorReal-1.02-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f709d5a926

FEDORA-2025-f709d5a926 (perl-Math-VectorReal-1.02-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.