Bug 241758
Summary: | Review Request: xar - The eXtensible ARchiver | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matthias Saou <matthias> |
Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | jochen:
fedora-review+
j: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.5-1.fc7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-06-18 16:39:46 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Matthias Saou
2007-05-30 13:13:37 UTC
Good: + Rpmlint quite on source rpm. + Sources matches with upstream. + License ok. + Naming ok. + Local build works fine. + Rpmlint quite on xar main package. + Rpmlint quite on debuginfo package. + Package contains varbatin copy of the license text. + Local install and uninstall works fine + Local test of the application works fine. + Mock build works fine. Bad: - Bad Buildroot: BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Duplicate BuildRequites: Duplicate BuildRequires: zlib-devel (by libxml2-devel) - xar-devel contains no docs. - Buildroot : "should", not "must", I'm getting tired of this one :-/ - Duplicate buildrequires : Not really. The package checks explicitly for both, it's not if it was only relying on libxml2 and indirectly on zlib. I see no harm or problems in having both, and prefer like this in case the software switches to some other xml library in the future, which doesn't pull in zlib. - I don't recall any policy making docs mandatory in devel packages. You're probably relying on rpmlint output. The xar sources don't contain any API docs, so the devel package doesn't either. Thanks for taking the time to review, and so quickly too :-) Ok, for the Buildroot I have consult the packaging guildline and have find out, that you specified Buildroot is ok. So, becouse there are no open topics noew, I can approve your package. *** APPROVED *** Thanks for the review! I had forgotten about it because the bug wasn't ASSIGNED, though. New Package CVS Request ======================= Package Name: xar Short Description: The eXtensible ARchiver Owners: matthias Branches: F7 FC6 FC5 EL5 EL4 devel (all current) InitialCC: CVS done. Thanks! All imported, built and pushed. xar-1.5-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |