Bug 241765
Summary: | valid mkfs'd ext3 filesystem cannot be mounted or repaired | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Eric Sandeen <esandeen> |
Component: | e2fsprogs | Assignee: | Eric Sandeen <esandeen> |
Status: | CLOSED NEXTRELEASE | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | sct, tytso |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-10-08 18:12:12 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Eric Sandeen
2007-05-30 14:17:16 UTC
Simpler test: mke2fs -j -F -b 4096 -m 0 -N 5217280 /mnt/test/fsfile2 327680 it's an off by one in calculating whether the inode table is within the block group; this only triggers for odd geometries when the inode table lands on the last block of the first group) Index: e2fsprogs-1.40.2/lib/ext2fs/check_desc.c =================================================================== --- e2fsprogs-1.40.2.orig/lib/ext2fs/check_desc.c +++ e2fsprogs-1.40.2/lib/ext2fs/check_desc.c @@ -61,7 +61,7 @@ errcode_t ext2fs_check_desc(ext2_filsys */ if (fs->group_desc[i].bg_inode_table < first_block || ((fs->group_desc[i].bg_inode_table + - fs->inode_blocks_per_group) > last_block)) + fs->inode_blocks_per_group - 1) > last_block)) return EXT2_ET_GDESC_BAD_INODE_TABLE; } return 0; without this it thinks it's corrupt, and also doesn't fix it (e2fsck finds an "error" each time it's run) Same fix needs to go into the kernel, in ext3_check_descriptors() Probably not a very high priority, although it's not *too* hard to hit; simply making a ~2T (though actually less...) 1k-block filesystem will trigger it. and an even smaller fs useful for the regression test: mkfs.ext2 -F -b 1024 -m 0 -g 256 -N 3744 fsfile 1024 patch sent upstream Ted, putting you on cc: in case you want to reference the RH bug nr. e2fsprogs patch is upstream, http://git.kernel.org/?p=fs/ext2/e2fsprogs.git;a=commitdiff;h=bd828a27e2cfec9f14837d9a693e2a414f44bf91 (Note to self, might want another bug for the same issue on the kernel side.) moving to fedora as product; yes, this exists on rhel too but it's a bit obscure and has never been reported... Going to just close this one as NEXTRELEASE; next upstream e2fsprogs will havve this fix. I don't think it's critical to pull it to fedora for now. |