Bug 2418596

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9863300
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418596-perl-chemistry-file-xyz/fedora-rawhide-x86_64/09863300-perl-Chemistry-File-XYZ/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 

FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
FIX: Please specify all dependencies in BuildRequires
     perl(base) - Chemistry-File-XYZ-0.11/XYZ.pm:6
     perl(Carp) - Chemistry-File-XYZ-0.11/XYZ.pm:8
     perl(Chemistry::File) - Chemistry-File-XYZ-0.11/XYZ.pm:6
     perl(strict) - Chemistry-File-XYZ-0.11/XYZ.pm:9
     perl(warnings) - Chemistry-File-XYZ-0.11/XYZ.pm:10

$ rpm -qp --requires perl-Chemistry-File-XYZ-0.11-1.fc44.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(Chemistry::File)
      1 perl(Chemistry::Mol)
      1 perl-libs
      1 perl(strict)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Chemistry-File-XYZ-0.11-1.fc44.noarch.rpm | sort | uniq -c
      1 perl(Chemistry::File::XYZ) = 0.11
      1 perl-Chemistry-File-XYZ = 0.11-1.fc44
Binary provides are Ok.

$ rpmlint perl-Chemistry-File-XYZ-0.11-1.fc44.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

perl-Chemistry-File-XYZ.noarch: E: spelling-error ('Mol', '%description -l en_US Mol -> Mo, Moll, Moe')
 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 0.1 s

Rpmlint is ok

NOTE: Is there any special reason why you use control via 'check' macro?

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.

Resolution:
NOT Approved

Thanks for the review, Jitka!

Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-File-XYZ/perl-Chemistry-File-XYZ.spec
SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-File-XYZ/perl-Chemistry-File-XYZ-0.11-1.fc44.src.rpm

(In reply to Jitka Plesnikova from comment #2)
> FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> FIX: Please specify all dependencies in BuildRequires
>      perl(base) - Chemistry-File-XYZ-0.11/XYZ.pm:6
>      perl(Carp) - Chemistry-File-XYZ-0.11/XYZ.pm:8
>      perl(Chemistry::File) - Chemistry-File-XYZ-0.11/XYZ.pm:6
>      perl(strict) - Chemistry-File-XYZ-0.11/XYZ.pm:9
>      perl(warnings) - Chemistry-File-XYZ-0.11/XYZ.pm:10

All added.

[...]
> NOTE: Is there any special reason why you use control via 'check' macro?

Just a force of habit. Some of the other perl packages in this stack had circular build dependencies.
Dropped from this one.

> Otherwise the package is in line with Fedora and Perl packaging guide lines.
> Please correct all 'FIX' items,

Done.

> consider fixing 'TODO' items

I don't see any in your review.

> and provide a new spec file.

Done.

That should be:

Spec URL: https://rathann.fedorapeople.org/review/perl-Chemistry-File-XYZ/perl-Chemistry-File-XYZ.spec
SRPM URL: https://rathann.fedorapeople.org/review/perl-Chemistry-File-XYZ/perl-Chemistry-File-XYZ-0.11-1.fc45.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10304214
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418596-perl-chemistry-file-xyz/fedora-rawhide-x86_64/10304214-perl-Chemistry-File-XYZ/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Created attachment 2136392 [details]
The .spec file difference from Copr build 10304214 to 10304215

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10304215
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418596-perl-chemistry-file-xyz/fedora-rawhide-x86_64/10304215-perl-Chemistry-File-XYZ/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> FIX: Please specify all dependencies in BuildRequires
>      perl(base) - Chemistry-File-XYZ-0.11/XYZ.pm:6
>      perl(Carp) - Chemistry-File-XYZ-0.11/XYZ.pm:8
>      perl(Chemistry::File) - Chemistry-File-XYZ-0.11/XYZ.pm:6
>      perl(strict) - Chemistry-File-XYZ-0.11/XYZ.pm:9
>      perl(warnings) - Chemistry-File-XYZ-0.11/XYZ.pm:10
+BuildRequires:  coreutils
 BuildRequires:  make
 BuildRequires:  perl-generators
 BuildRequires:  perl-interpreter
-BuildRequires:  perl(ExtUtils::MakeMaker)
-%if %{with check}
+BuildRequires:  perl(base)
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(Chemistry::File)
 BuildRequires:  perl(Chemistry::Mol)
+BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Test::Pod)
-%endif
Done.

> NOTE: Is there any special reason why you use control via 'check' macro?
-
-%bcond check 1
-
...
-%if %{with check}
 %check
 make test
-%endif

Thanks for removing

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Chemistry-File-XYZ
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

FEDORA-2026-4a38be1571 (perl-Chemistry-File-XYZ-0.11-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-4a38be1571

FEDORA-2026-4a38be1571 (perl-Chemistry-File-XYZ-0.11-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.