Bug 2418762
| Summary: | Review Request: smallstep - private CA with ACME | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stuart D Gathman <stuart> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lx, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Stuart D Gathman
2025-12-04 04:04:19 UTC
Spec URL: https://gathman.org/linux/SPECS/smallstep.spec SRPM URL: https://gathman.org/linux/f44/src/smallstep-0.28.4-9.fc44.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/9864490 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418762-smallstep/fedora-rawhide-x86_64/09864490-smallstep/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/9864495 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418762-smallstep/fedora-rawhide-x86_64/09864495-smallstep/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The auto review doesn't like 1.3M in /usr/share - but this is all LICENSE and NOTICE files. This seems unavoidable with the fragmented golang libraries. Install on a fresh vm fails because -r on useradd prevents creating home dir. Need new release. New vendor version up as well. Spec URL: https://gathman.org/linux/SPECS/smallstep.spec SRPM URL: https://gathman.org/linux/SRPMS/smallstep-0.29.0-2.fc44.src.rpm New upstream release, switch to systemd-sysusers for service uid. Created attachment 2131365 [details]
The .spec file difference from Copr build 9864495 to 10178465
Copr build: https://copr.fedorainfracloud.org/coprs/build/10178465 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418762-smallstep/fedora-rawhide-x86_64/10178465-smallstep/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause AND ISC AND LicenseRef-scancode-proprietary-license AND MIT AND MPL-2.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://gathman.org/linux/SPECS/smallstep.spec SRPM URL: https://gathman.org/linux/SRPMS/smallstep-0.29.0-3.fc44.src.rpm The vendored module askalono couldn't recognize was github.com/google/go-tpm-tools/LICENSE The LICENSE files concatenates submodule LICENSES, and the vendored archive does not include the simulator/ms-tpm-20-ref submodule - the submodule with the incompatible license. I edited License: in the spec to remove the LicenseRef-scancode-proprietary-license (after confirming the only the ms-tpm-20-ref license was flagged as that by askalono). I added a comment to explain why I changed the output of go_vendor_license. I'm not sure if that is the correct way to handle this situation. For one thing, I have to do it for every upgrade - but then licenses have to be re-examined anyway. If I'm reading the go-tpm-tools LICENSE wrong, let me know. IANAL Created attachment 2132110 [details]
The .spec file difference from Copr build 10178465 to 10191682
Copr build: https://copr.fedorainfracloud.org/coprs/build/10191682 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418762-smallstep/fedora-rawhide-x86_64/10191682-smallstep/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://gathman.org/linux/SPECS/smallstep.spec SRPM URL: https://gathman.org/linux/SRPMS/smallstep-0.29.0-3.fc44.src.rpm Update go-vendor-tools.toml to remove licenses for ms-tpm-20-ref submodule (which is NOT vendored). I asked on legal mailing list, and while it seems fairly clear that "Microsoft simulator code (in simulator/ms-tpm-20-ref) uses the following licenses" means that *all* of the following licenses apply to ms-tpm-20-ref, I will also ask for additional clarification on github.com/google/go-tpm-tools . Created attachment 2132329 [details]
The .spec file difference from Copr build 10191682 to 10198338
Copr build: https://copr.fedorainfracloud.org/coprs/build/10198338 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2418762-smallstep/fedora-rawhide-x86_64/10198338-smallstep/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |