Bug 2419651

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9881431
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2419651-octave-datatypes/fedora-rawhide-x86_64/09881431-octave-datatypes/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://orion.fedorapeople.org/octave-datatypes.spec
SRPM URL: https://orion.fedorapeople.org/octave-datatypes-1.1.0-1.fc44.src.rpm

Try setting TZ.

Created attachment 2117773 [details]
The .spec file difference from Copr build 9881431 to 9882756

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9882756
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2419651-octave-datatypes/fedora-rawhide-x86_64/09882756-octave-datatypes/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I don't know what's different between the copr environment and koji that is triggering the issue.

https://koji.fedoraproject.org/koji/taskinfo?taskID=139779060

Picking this review.

The usual warning applies, this package is getting updates at a regular periods and so 1.1.0 is no longer the last version.

At this time it is 1.2.0 (released 3 days ago).

Spec URL: https://orion.fedorapeople.org/octave-datatypes.spec
SRPM URL: https://orion.fedorapeople.org/octave-datatypes-1.2.0-1.fc45.src.rpm

Update to 1.2.0

https://koji.fedoraproject.org/koji/taskinfo?taskID=143183131

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10205405
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2419651-octave-datatypes/fedora-rawhide-x86_64/10205405-octave-datatypes/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- License file LICENSE is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Everything in this package is correct, my main issue is regarding the license field.

In particular the following files have a license different from the stated:

* src/tz.cpp (MIT as defined in the header);
* the package's logo ('doc/datatypes.png') is licensed under a Creative Commons
Attribution-ShareAlike 4.0 International license (CC BY-SA 4.0). (as defined in the LICENSE.txt file).
* inst/tzdata/leap-seconds.list (Public Domain)

So, if I understand this, the License field should be:

```
License: GPL-3.0-or-later AND MIT AND CC-BY-SA-4.0 AND LicenseRef-Fedora-Public-Domain
```

On the other I said that I expected this review not to be out before the next stable release (1.2.1).
I was wrong (in hindsight I should have (probably) delayed this review in order to be right). :-D

Feel free, if you see the comment regarding the license to be fit, to fix this on import.

This package is APPROVED.

Just to be complete:

* The license(s) of the package is/(are) permissible in Fedora.
* The package spec is clean, well written and follows the best standards for Octave packages.

Thanks for the review.  I don't see 1.2.1 myself.

tz.cpp is not being built - I'm now removing it in %prep.  I'll make the other other license notes.

The Pagure repository was created at https://src.fedoraproject.org/rpms/octave-datatypes

FEDORA-2026-eba0b1f017 (octave-datatypes-1.2.0-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-eba0b1f017

FEDORA-2026-eba0b1f017 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-eba0b1f017 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-eba0b1f017

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2026-eba0b1f017 (octave-datatypes-1.2.0-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.