Bug 2420028

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9886385
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2420028-python-sse-starlette/fedora-rawhide-x86_64/09886385-python-sse-starlette/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This package won't land on Fedora 42. Only F43+

This SRPM is not executing any of the tests yet. I'm trying to fix it in the background, but noticed that two tests dependencies are missing from Fedora. I'm working with my colleagues to get this done first.

Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/python-sse-starlette/fedora-rawhide-x86_64/10062110-python-sse-starlette/python-sse-starlette.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/python-sse-starlette/fedora-rawhide-x86_64/10062110-python-sse-starlette/python-sse-starlette-3.2.0-1.fc44.src.rpm

The SRPM link file is broken. Using: https://download.copr.fedorainfracloud.org/results/r0x0d/python-sse-starlette/srpm-builds/10015225/python-sse-starlette-3.0.3-3.fc44.src.rpm to review.

Created attachment 2123869 [details]
The .spec file difference from Copr build 9886385 to 10065215

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10065215
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2420028-python-sse-starlette/fedora-rawhide-x86_64/10065215-python-sse-starlette/fedora-review/review.txt

Found issues:

- python3-async-timeout is deprecated, you must not depend on it.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/python-sse-starlette/fedora-rawhide-x86_64/10066919-python-sse-starlette/python-sse-starlette.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/python-sse-starlette/fedora-rawhide-x86_64/10066919-python-sse-starlette/python-sse-starlette-3.2.0-1.fc44.src.rpm

Package Naming
[X] Package is named according to Fedora guidelines
[X] Follows python package naming (python-modulename)
Spec File Formatting
[X] Name, Version, Release, Summary present
[X] License is valid SPDX identifier
[X] URL points to upstream project
[X] Source0 uses proper macros and points to valid source
License
[X] License field matches actual license
[X] License file included in %files (%license LICENSE)
BuildRequires
[X] BuildRequires include python3-devel
[X] BuildRequires include necessary build tools
[X] Test dependencies are included
Build Process
[X] Uses appropriate build system (pyproject)
[X] BuildArch: noarch is set (pure Python package)
[X] %prep section uses %autosetup
[X] %pyproject_extras_subpkg macro used for extras
Files Section
[X] %files uses %pyproject_files macro
[X] License file marked with %license
Check Section
[X] %pyproject_check_import present
[X] %pytest or equivalent test execution present
Changelog
[X] Changelog entries present
[X] Changelog follows Fedora format
Description
[X] %description present
[X] Subpackage description present
Summary
[X] Summary is concise and descriptive
[X] Summary does not end with period
Source Verification
[X] Source URL is valid and versioned
General MUST Items
[X] Package meets Fedora Packaging Guidelines
[X] Spec file name matches base package name
[X] Package successfully compiles and builds
[X] License is acceptable for Fedora
[X] License text included in package
[X] All build dependencies listed
[X] Locale data handled properly (N/A for this package)
[X] %check section runs appropriate tests

RPM lint check: 
┌─[priscila@Hyrule]─[~/RedHat/lightspeed/packages/python-sse-starlette]─[(rawhide)
└─▶▶▶▶ rpmlint python-sse-starlette.spec 
========================================================== rpmlint session starts =========================================================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

===================== 0 packages and 1 specfiles checked; 0 errors, 0 warnings, 1 filtered, 0 badness; has taken 0.2 s ====================


Latest passing build: https://copr.fedorainfracloud.org/coprs/r0x0d/python-sse-starlette/build/10066919/
Latest specfile: https://download.copr.fedorainfracloud.org/results/r0x0d/python-sse-starlette/fedora-43-x86_64/10066919-python-sse-starlette/python-sse-starlette.spec

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sse-starlette

FEDORA-2026-7326cc8311 (python-sse-starlette-3.2.0-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-7326cc8311

FEDORA-2026-7326cc8311 (python-sse-starlette-3.2.0-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2026-c25bbb7b7e (python-sse-starlette-3.2.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-c25bbb7b7e

FEDORA-2026-c25bbb7b7e has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-c25bbb7b7e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-c25bbb7b7e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2026-c25bbb7b7e (python-sse-starlette-3.2.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Package Information
[X] Package name follows naming guidelines (python-sse-starlette)
[X] Version is present and appropriate (3.2.0)
[X] Release uses %autorelease (rpmautospec)
[X] Summary is concise and descriptive
[X] License is specified correctly (BSD-3-Clause)
[X] URL points to upstream project
[X] Source0 uses proper URL with version macro
BuildRequires and Dependencies
[X] BuildArch: noarch is appropriate (pure Python)
[X] python3-devel is listed
[X] BuildSystem: pyproject is used
[X] BuildRequires includes necessary test dependencies
[X] tomcli is included (used for dependency relaxation)
Spec File Structure
[X] %description is present and clear
[X] Subpackage python3-sse-starlette is properly defined
[X] %prep section uses %autosetup
[X] Patch level (-p1) is specified
[X] %files section uses %{pyproject_files}
[X] %license macro is used correctly
Building and Testing
[X] %pyproject_extras_subpkg is used for extras
[X] BuildOption(install) specifies correct module
[X] BuildOption(generate_buildrequires) includes extras
[X] %check section exists
[X] %pyproject_check_import is included
[X] %pytest is used with appropriate --ignore flag