Bug 2421450
| Summary: | Review Request: go-l2tp - L2TPv2 client written in golang | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Parkin <tparkin> |
| Component: | Package Review | Assignee: | Maxwell G <maxwell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dreua, maxwell, mhroncok, package-review |
| Target Milestone: | --- | Flags: | maxwell:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-01-05 22:11:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tom Parkin
2025-12-11 19:00:31 UTC
This package is APPROVED, but please make sure to read the special notes at the end of this review before proceeding with importing this package. Thank you! Vendored Go Package Review ============== Source: <https://git.sr.ht/~gotmax23/fedora-scripts/tree/main/item/go-sig/vendored_review_template.md> This package was generated using go2rpm and Go Vendor Tools, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The specfile is legible. - [x] The SRPM contains a valid `go-vendor-tools.toml`. - The default `detector = "askalono"` is included unless there is justification. - Manual license overrides are correct. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) (This is a package rename so n/a) - [x] There are no `%{_bindir}/*` wildcards in %files. - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the rest of the Golang and general Packaging Guidelines. - [x] The Obsoletes and Provides are correct Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org. - [ ] Give go-sig privileges (at least commit) on the package. - [ ] Close the review bug by referencing its ID in the commit message and the Bodhi ticket. SPECIAL NOTES: - [ ] When importing this package, you should preserve the old history from golang-github-katalix-l2tp. When requesting the repo with `fedpkg request-repo`, make sure to pass `--no-initial-commit`. This way, you can just push the exact contents of the old repository to the new repository and then create a new commit on top for the package rename. Let me know if you have any questions about this. This step is important here, as the rpmautospec changelog and release number generation and the obsoletes that rely on the release numbering will get messed up without the history. - [ ] You should only need to build the new package in rawhide. The old golang libraries will not be removed from stable branches, so you can keep the old golang-github-katalix-l2tp there. - [ ] Retire the original golang-github-katalix-l2tp package with `fedpkg retire` on rawhide after this new package is imported, built, and pushed by Bodhi. Thanks! The Pagure repository was created at https://src.fedoraproject.org/rpms/go-l2tp > When requesting the repo with `fedpkg request-repo`, make sure to pass `--no-initial-commit`. This was done, thanks! I manually created the main branch alias at https://src.fedoraproject.org/rpms/go-l2tp/settings#gitbranch-tab (this step is normally done automatically, but not when --no-initial-commit is used). I made a bit of a mistake with the `fedpkg` workflow such that the Bodhi ticket[1] doesn't reference this one and hence hasn't automatically closed it. Is there a way to associate this ticket with the Bodhi state after the event? Or alternatively should I manually close this ticket? [1]. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f4e54c7dca I think there is one item left to do, otherwise I'd say you can just set the Status of this bug to Closed / Errata. (Automation is nice to have but not necessary for this afaik.) (In reply to Maxwell G from comment #1) > - [ ] Retire the original golang-github-katalix-l2tp package with `fedpkg > retire` on rawhide after this new package is imported, built, and pushed by > Bodhi. (In reply to David Auer from comment #5) > I think there is one item left to do, otherwise I'd say you can just set the > Status of this bug to Closed / Errata. (Automation is nice to have but not > necessary for this afaik.) > > (In reply to Maxwell G from comment #1) > > - [ ] Retire the original golang-github-katalix-l2tp package with `fedpkg > > retire` on rawhide after this new package is imported, built, and pushed by > > Bodhi. Thanks David, I've retired golang-github-katalix-l2tp now so I will close this bug accordingly. |