Bug 2422277
| Summary: | Review Request: rust-soft_assert - Non-panicking assertions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Menšík <pemensik> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | POST --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, michel, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
michel: needinfo? (pemensik) |
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://crates.io/crates/soft_assert | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2422294 | ||||||
| Attachments: |
|
||||||
|
Description
Petr Menšík
2025-12-15 14:39:45 UTC
Anubis failed scratch build results. It passed two times: - https://koji.fedoraproject.org/koji/taskinfo?taskID=140052450 - https://koji.fedoraproject.org/koji/taskinfo?taskID=140052293 Copr build: https://copr.fedorainfracloud.org/coprs/build/9914365 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2422277-rust-soft_assert/fedora-rawhide-x86_64/09914365-rust-soft_assert/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/soft_assert-0.1.1/src/lib.rs W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/soft_assert-0.1.1/README.MD You'll need to fix that somehow (either with sed or dos2unix). rust2rpm v28 should have printed a warning for this issue - if it didn't, please let me know. Are you still interested in this package? Sure, sorry for delays! Yes, I still want this package. No new version came since the last time. I wanted to prepare forgejo-api depending on this. Spec URL: https://github.com/pemensik/soft_assert/raw/refs/heads/fedora/rust-soft_assert.spec SRPM URL: https://github.com/pemensik/soft_assert/raw/refs/heads/fedora/rust-soft_assert-0.1.1-2.fc45.src.rpm rust2rpm.toml URL: https://github.com/pemensik/soft_assert/raw/refs/heads/fedora/rust2rpm.toml Created attachment 2138649 [details]
The .spec file difference from Copr build 9914365 to 10406805
Copr build: https://copr.fedorainfracloud.org/coprs/build/10406805 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2422277-rust-soft_assert/fedora-rawhide-x86_64/10406805-rust-soft_assert/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks for the update. It looks like rpmlint only warned about the first two occurrences of those warnings /errors - in fact, *all* files included in the crate have CRLF line endings (except those generated by cargo during the publishing process). Please fix all of them, and I would also recommend to use the "--keepdate" flag for dos2unix to avoid changing the file timestamps. Neither are blocking issues, please just address them before importing the package. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) Petr, are you still interested in this? I also want to get forgejo-api (and later forgejo-cli) packaged |