Bug 242228
| Summary: | Review Request: ps2eps - PS-to-EPS converter | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Terje Røsten <terje.rosten> | ||||
| Component: | Package Review | Assignee: | Patrice Dumas <pertusus> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | orion, pertusus | ||||
| Target Milestone: | --- | Flags: | pertusus:
fedora-review+
j: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-06-06 15:14:24 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Terje Røsten
2007-06-02 11:43:24 UTC
I suggest adding -p to the man pages install command to keep timestamps. Also I suggest using %defattr (-, root, root, -) instead of %defattr (-, root, root). INSTALL.txt shouldn't be shipped. bbox is a bit too generic for a program name that is mainly used from another application. I think it could be discussed with upstream. Created attachment 155988 [details]
fix insecure tmp use + add shebang
This patch hopefully fixes an insecure use of tmp bug. I
also patched the shebang at the same time. I think that the
issue should really be brought up upstream.
> This patch hopefully fixes an insecure use of tmp bug. I > also patched the shebang at the same time. I think that the > issue should really be brought up upstream. Thanks, will send upstream a mail, here is new spec and srpms: Spec URL: http://web.phys.ntnu.no/~terjeros/ps2eps/ps2eps.spec SRPM URL: http://web.phys.ntnu.no/~terjeros/ps2eps/ps2eps-1.64-2.fc7.src.rpm * rpmlint is silent * free software, license included * follow packaging guidelines * spec is legible * sane provides * source match upstream 89aec3f075cee662f2367b12337b5c3e ps2eps-1.64.tar.gz * %files section right APPROVED - please bring the issue of the bbox name to upstream - I personally prefer adding explicitly names in %files to know when things change. This is only a suggestion/personal preference. > APPROVED Thanks! > - please bring the issue of the bbox name to upstream Ok. > - I personally prefer adding explicitly names in %files to > know when things change. Yeah, a nice advise, however not critical is this case as files is installed by hand and not by e.g. configure && make && make install New Package CVS Request ======================= Package Name: ps2eps Short Description: PS-to-EPS converter Owners: terjeros.no Branches: FC-5 FC-6 F-7 InitialCC: (In reply to comment #5) > Yeah, a nice advise, however not critical is this case as files is installed by > hand and > not by e.g. configure && make && make install Indeed! You are so right. cvs done Package Change Request ====================== Package Name: ps2eps New Branches: EL-5 Owners: pertusus Terje agreed by mail that I could maintain the EPEL branch. Terje, I think that you should confirm here. Also tell if you want to be comaintaner of EPEL branches. I can confirm that, thanks Pat! CVS Done Package Change Request ====================== Package Name: ps2eps New Branches: el6 Owners: orion In private communication Orion and I agreed that Orion will maintain EPEL 6 branches of ps2eps, thanks! Git done (by process-git-requests). |