Bug 2423802

Created attachment 2119218 [details]
Configuration file for rust2rpm

I uploaded the wrong rust2rpm.toml in the initial submission.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9934062
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2423802-rust-datatest-stable/fedora-rawhide-x86_64/09934062-rust-datatest-stable/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9934063
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2423802-rust-datatest-stable/fedora-rawhide-x86_64/09934063-rust-datatest-stable/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package looks good to me, with a few minor things that I trust you can address before importing:

- Exclude the scripts/ folder from the package. It causes a dependency on /bin/bash.
- Maybe also exclude the tests/files folder. It contains only test input files.
- Similarly, Justfile and release.toml are only valuable for upstream development.

An exclusion rule for .cargo/, scripts/, Justfile, and release.toml might be acceptable for upstream too.

===

Package was generated with rust2rpm, simplifying the review.
The downstream Cargo.toml patch is justified and documented.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Thank you for the review!

(In reply to Fabio Valentini from comment #4)
> Package looks good to me, with a few minor things that I trust you can
> address before importing:
> 
> - Exclude the scripts/ folder from the package. It causes a dependency on
> /bin/bash.

Good catch. I always try to check for this, but occasionally forget.

> - Maybe also exclude the tests/files folder. It contains only test input
> files.

Hmm. On the one hand, the tests still pass if I do this. On the other hand, the tests tests/compile-fail/*.rs are running in the package build, and their sources indicate they should rely on these files, so perhaps removing these files is undermining these tests by making compilation fail for the wrong reason? I think that rather than looking at this in detail, I’ll just leave these (small and not very numerous) files in for now.

> - Similarly, Justfile and release.toml are only valuable for upstream
> development.
> 
> An exclusion rule for .cargo/, scripts/, Justfile, and release.toml might be
> acceptable for upstream too.

https://github.com/nextest-rs/datatest-stable/pull/424

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-datatest-stable

FEDORA-2025-93d14ba696 (rust-datatest-stable-0.3.3-2.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-93d14ba696

FEDORA-2025-93d14ba696 (rust-datatest-stable-0.3.3-2.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.