Bug 2426937
| Summary: | Review Request: qlog - Qt Logging program for ham-radio operators | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Alessandro Locati <me> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | benson_muite, fedora, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/foldynl/QLog | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Fabio Alessandro Locati
2026-01-03 11:13:02 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9973489 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2426937-qlog/fedora-rawhide-x86_64/09973489-qlog/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Please add an appdata file: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ There is an option to build with Qt6: https://github.com/foldynl/QLog/blob/master/.github/workflows/c-cpp.yml#L48 assuming it works correctly, that would be preferred to Qt5 which will not receive any updates. Thanks! I've integrated the suggestions :) Spec URL: https://fale.fedorapeople.org/qlog/qlog.spec SRPM URL: https://fale.fedorapeople.org/qlog/qlog-0.47.1-1.fc43.src.rpm Created attachment 2121301 [details]
The .spec file difference from Copr build 9973489 to 9979723
Copr build: https://copr.fedorainfracloud.org/coprs/build/9979723 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2426937-qlog/fedora-rawhide-x86_64/09979723-qlog/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. New version is available: Spec URL: https://fale.fedorapeople.org/qlog/qlog.spec SRPM URL: https://fale.fedorapeople.org/qlog/qlog-0.48.0-1.fc43.src.rpm Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=141879749 Created attachment 2128178 [details]
The .spec file difference from Copr build 9979723 to 10093777
Copr build: https://copr.fedorainfracloud.org/coprs/build/10093777 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2426937-qlog/fedora-rawhide-x86_64/10093777-qlog/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. New version is available: Spec URL: https://fale.fedorapeople.org/qlog/qlog.spec SRPM URL: https://fale.fedorapeople.org/qlog/qlog-0.50.0-1.fc44.src.rpm Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=144903956 > ExclusiveArch: x86_64 aarch64 I'm guessing this is because of qtwebengine? In which case, you should use %{qt6_qtwebengine_arches} here. > Source0: https://github.com/foldynl/QLog/archive/refs/tags/v%{version}.tar.gz#/%{name}-%{version}.tar.gz You can avoid the #/ renaming trick by using ".../tags/v%{version}/%{name}-%{version}.tar.gz". > %description > It is based on the Qt 5 framework and uses SQLite as database backend. You're building with Qt6, so drop the number here or change it to 6. Thanks a lot Artur, I've implemented your suggestions :). New version is available: Spec URL: https://fale.fedorapeople.org/qlog/qlog.spec SRPM URL: https://fale.fedorapeople.org/qlog/qlog-0.50.0-1.fc44.src.rpm Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=145085278 Created attachment 2139365 [details]
The .spec file difference from Copr build 10093777 to 10421890
Copr build: https://copr.fedorainfracloud.org/coprs/build/10421890 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2426937-qlog/fedora-rawhide-x86_64/10421890-qlog/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > License: GPL-3.0-or-later This covers only original code, but it seems there are some files borrowed from other projects which are under different licences. Running licensecheck says: > BSD 3-Clause License > -------------------- > qlog-0.50.0-build/QLog-0.50.0/core/zonedetect.c > qlog-0.50.0-build/QLog-0.50.0/core/zonedetect.h > qlog-0.50.0-build/QLog-0.50.0/devtools/timezones/builder/builder.cpp > > MIT License > ----------- > qlog-0.50.0-build/QLog-0.50.0/core/csv.hpp > > ODC Open Database License v1.0 > ------------------------------ > qlog-0.50.0-build/QLog-0.50.0/devtools/timezones/timezone_DATA_LICENSE Also, looking at the upstream code, it seems that there's a file containing timezone data, at "res/data/timezone21.bin". Is this file embedded into the executable? If it is, then its license should also be taken into account. If it's not embedded - is it loaded at runtime? It's not included in the resulting RPM package. Thanks Artur! "res/data/timezone21.bin" is embedded. I've added the additional licenses and bumped to the newest version. Spec URL: https://fale.fedorapeople.org/qlog/qlog.spec SRPM URL: https://fale.fedorapeople.org/qlog/qlog-0.51.0-1.fc44.src.rpm Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=146666961 |