Bug 2427010

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9973947
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427010-quickshell/fedora-rawhide-x86_64/09973947-quickshell/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Package validates %{name}.desktop using desktop-file-validate %check
  https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage

- Missing BSD-3-Clause and HPND-sell-variant in License field
  - BSD-3-Clause for Hyprland-related protocols
  - HPND-sell-variant for wlr-layer-shell-unstable-v1

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[!]: Rpath absent or only used for internal libs.
     Note: See rpmlint output
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License,
     Version 3", "*No copyright* GNU Lesser General Public License, Version
     3", "Historical Permission Notice and Disclaimer - sell variant and/or
     NTP License (legal disclaimer)", "BSD 3-Clause License". 452 files
     have unknown license. Detailed output of licensecheck in
     /home/error/tmp/t98/2427010-quickshell/licensecheck.txt
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 22529 bytes in 6 files.
[!]: Package complies to the Packaging Guidelines
     Note: aforementioned issues
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: quickshell-0.2.1-7.fc44.x86_64.rpm
          quickshell-0.2.1-7.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpt1lf_fki')]
checks: 32, packages: 2

quickshell.x86_64: W: no-manual-page-for-binary qs
quickshell.x86_64: W: no-manual-page-for-binary quickshell
quickshell.spec: W: no-%check-section
quickshell.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/Quickshell/I3/quickshell-i3.qmltypes /usr/lib64/qt6/qml/Quickshell/Hyprland/quickshell-hyprland.qmltypes
quickshell.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/quickshell (RUNPATH: $ORIGIN:$ORIGIN/../lib64)
 2 packages and 0 specfiles checked; 1 errors, 4 warnings, 8 filtered, 1 badness; has taken 1.2 s 




Rpmlint (debuginfo)
-------------------
Checking: quickshell-debuginfo-0.2.1-7.fc44.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpzng9e4of')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 5.8 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

quickshell.x86_64: E: spelling-error ('lockscreens', '%description -l en_US lockscreens -> lock screens, lock-screens, silkscreens')
quickshell.x86_64: W: no-manual-page-for-binary qs
quickshell.x86_64: W: no-manual-page-for-binary quickshell
quickshell.x86_64: W: cross-directory-hard-link /usr/lib64/qt6/qml/Quickshell/I3/quickshell-i3.qmltypes /usr/lib64/qt6/qml/Quickshell/Hyprland/quickshell-hyprland.qmltypes
quickshell.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/quickshell (RUNPATH: $ORIGIN:$ORIGIN/../lib64)
 2 packages and 0 specfiles checked; 2 errors, 3 warnings, 10 filtered, 2 badness; has taken 1.5 s 



Source checksums
----------------
https://git.outfoxxed.me/quickshell/quickshell/archive/v0.2.1.tar.gz#/quickshell-0.2.1.tar.gz :
  CHECKSUM(SHA256) this package     : d815c5f99f4a0a28545ffaa90464420c773b7c0ab62f713d9d8735a8e7282ca7
  CHECKSUM(SHA256) upstream package : d815c5f99f4a0a28545ffaa90464420c773b7c0ab62f713d9d8735a8e7282ca7


Requires
--------
quickshell (rpmlib, GLIBC filtered):
    (qt6-qtwayland(x86-64) if qt6-qtbase(x86-64) < 6.10)
    libEGL.so.1()(64bit)
    libOpenGL.so.0()(64bit)
    libQt6Core.so.6()(64bit)
    libQt6Core.so.6(Qt_6)(64bit)
    libQt6Core.so.6(Qt_6.10)(64bit)
    libQt6Core.so.6(Qt_6.10_PRIVATE_API)(64bit)
    libQt6DBus.so.6()(64bit)
    libQt6DBus.so.6(Qt_6)(64bit)
    libQt6Gui.so.6()(64bit)
    libQt6Gui.so.6(Qt_6)(64bit)
    libQt6Gui.so.6(Qt_6.10_PRIVATE_API)(64bit)
    libQt6Network.so.6()(64bit)
    libQt6Network.so.6(Qt_6)(64bit)
    libQt6Qml.so.6()(64bit)
    libQt6Qml.so.6(Qt_6)(64bit)
    libQt6Qml.so.6(Qt_6.10_PRIVATE_API)(64bit)
    libQt6Quick.so.6()(64bit)
    libQt6Quick.so.6(Qt_6)(64bit)
    libQt6Quick.so.6(Qt_6.10_PRIVATE_API)(64bit)
    libQt6WaylandClient.so.6()(64bit)
    libQt6WaylandClient.so.6(Qt_6)(64bit)
    libQt6WaylandClient.so.6(Qt_6.10_PRIVATE_API)(64bit)
    libQt6Widgets.so.6()(64bit)
    libQt6Widgets.so.6(Qt_6)(64bit)
    libc.so.6()(64bit)
    libdrm.so.2()(64bit)
    libgbm.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libjemalloc.so.2()(64bit)
    libm.so.6()(64bit)
    libpam.so.0()(64bit)
    libpam.so.0(LIBPAM_1.0)(64bit)
    libpam.so.0(LIBPAM_1.4)(64bit)
    libpipewire-0.3.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libwayland-client.so.0()(64bit)
    libxcb.so.1()(64bit)
    qt6-qtsvg(x86-64)
    rtld(GNU_HASH)



Provides
--------
quickshell:
    PolicyKit-authentication-agent
    application()
    application(org.quickshell.desktop)
    desktop-notification-daemon
    qt6qml(Quickshell)
    qt6qml(Quickshell.Bluetooth)
    qt6qml(Quickshell.DBusMenu)
    qt6qml(Quickshell.Hyprland)
    qt6qml(Quickshell.Hyprland._FocusGrab)
    qt6qml(Quickshell.Hyprland._GlobalShortcuts)
    qt6qml(Quickshell.Hyprland._Ipc)
    qt6qml(Quickshell.Hyprland._SurfaceExtensions)
    qt6qml(Quickshell.I3)
    qt6qml(Quickshell.I3._Ipc)
    qt6qml(Quickshell.Io)
    qt6qml(Quickshell.Services.Greetd)
    qt6qml(Quickshell.Services.Mpris)
    qt6qml(Quickshell.Services.Notifications)
    qt6qml(Quickshell.Services.Pam)
    qt6qml(Quickshell.Services.Pipewire)
    qt6qml(Quickshell.Services.SystemTray)
    qt6qml(Quickshell.Services.UPower)
    qt6qml(Quickshell.Wayland)
    qt6qml(Quickshell.Wayland._Screencopy)
    qt6qml(Quickshell.Wayland._ToplevelManagement)
    qt6qml(Quickshell.Wayland._WlrLayerShell)
    qt6qml(Quickshell.Widgets)
    qt6qml(Quickshell.X11)
    qt6qml(Quickshell._Window)
    quickshell
    quickshell(x86-64)



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2427010
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: R, Haskell, fonts, Ocaml, Python, PHP, SugarActivity, Java, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

(In reply to Ryan from comment #2)
> Issues:
> =======
> - Package validates %{name}.desktop using desktop-file-validate %check
>  
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_desktop_file_install_usage
> 
> - Missing BSD-3-Clause and HPND-sell-variant in License field
>   - BSD-3-Clause for Hyprland-related protocols
>   - HPND-sell-variant for wlr-layer-shell-unstable-v1
> 

These are addressed, I updated the spec and SRPM in place.

I believe you should add "-DCMAKE_SKIP_INSTALL_RPATH=ON" to the cmake flags as well, to resolve the rpath issue. I think it's coming from Qt (CMake), as it isn't explicitly set anywhere in upstream's source.

I've added that and updated the spec and SRPM.

Spec URL: https://ngompa.fedorapeople.org/for-review/quickshell.spec
SRPM URL: https://ngompa.fedorapeople.org/for-review/quickshell-0.2.1-7.fc43.src.rpm

Created attachment 2121406 [details]
The .spec file difference from Copr build 9973947 to 9981860

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9981860
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427010-quickshell/fedora-rawhide-x86_64/09981860-quickshell/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

LGTM now, package approved!

The Pagure repository was created at https://src.fedoraproject.org/rpms/quickshell