Bug 2427959
| Summary: | Review Request: texlive-collection-games - Games typesetting | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <spotrh> | ||||||
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | msuchy, package-review | ||||||
| Target Milestone: | --- | Flags: | msuchy:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | http://tug.org/texlive/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | --- | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2026-02-07 13:55:42 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Tom "spot" Callaway
2026-01-08 15:40:06 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/9987240 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427959-texlive-collection-games/fedora-rawhide-x86_64/09987240-texlive-collection-games/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/texlive-collection-games/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. New Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-games.spec New SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-games-svn76381-1.fc44.src.rpm Update to svn76381, update components, fix descriptions. Created attachment 2121954 [details]
The .spec file difference from Copr build 9987240 to 10001912
Copr build: https://copr.fedorainfracloud.org/coprs/build/10001912 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427959-texlive-collection-games/fedora-rawhide-x86_64/10001912-texlive-collection-games/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > LPPL-1.3c AND LGPL-2.1-only AND LicenseRef-Fedora-Public-Domain AND CC-BY-SA-4.0 AND LicenseRef-Fedora-Public-Domain AND MIT You may amend your tooling to include the LicenseRef-Fedora-Public-Domain only once when it is not in parenthesis. But this is not a blocker. > LicenseRef-cc-by-1 Not a valid license. > cp %{SOURCE123} %{buildroot}%{_datadir}/appdata/ You must validate the appdata. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage New Spec URL: https://spot.fedorapeople.org/tl2025/texlive-collection-games.spec New SRPM URL: https://spot.fedorapeople.org/tl2025/texlive-collection-games-svn76381-2.fc44.src.rpm Fixes license tags. validates appdata. Created attachment 2122995 [details]
The .spec file difference from Copr build 10001912 to 10039283
Copr build: https://copr.fedorainfracloud.org/coprs/build/10039283 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2427959-texlive-collection-games/fedora-rawhide-x86_64/10039283-texlive-collection-games/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. APPROVED The Pagure repository was created at https://src.fedoraproject.org/rpms/texlive-collection-games |