Bug 242840
Summary: | Bluecurve KWin theme shows pixel noise for "sticky" icon | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kevin Kofler <kevin> | ||||||
Component: | redhat-artwork | Assignee: | Than Ngo <than> | ||||||
Status: | CLOSED ERRATA | QA Contact: | |||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | 7 | ||||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | 7.0.0-11.fc7 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2007-06-28 01:54:23 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Kevin Kofler
2007-06-06 03:40:29 UTC
So, given that I'd have to look into that for Quarticurve-kwin (the KDE 4 port) anyway, I looked at the problem and found it: someone must have changed BASE_BUTTON_SIZE from 16 to 17 at some point, but the pixel data for the "pin" icons is all in 16×16. I'm currently trying to figure out the best way to fix it. (I have the icon itself fixed, but the masking is still not right in my current patch.) Created attachment 156535 [details]
Patch to fix "show on all desktops" in Bluecurve KWin theme
So this one is the good one. Masking now works too (I had to explicitly fill
the extra row and column there). Than, can you please apply this and push this
bugfix to F7 (maybe even FC6 too) ASAP?
Created attachment 156537 [details]
Corresponding specfile patch
And here's the corresponding specfile patch.
Kevin, i have taken a look at the patch, it looks fine. But i think it's better only change BASE_BUTTON_SIZE to 16. I will ask David as package maintainer to push this bugfix to F7. Thanks The reason I did my patch this way is that 1. I didn't know why and when BASE_BUTTON_SIZE was changed and 2. I didn't want to change the looks except for fixing that bug. BASE_BUTTON_SIZE is used in a few more places. Now that you got the KDE 3.5.7 updates out to testing, may I kindly remind you of this bug? It's now fixed in redhat-artwork-7_0_0-11_fc7. I will push it into F7 update today. Thanks redhat-artwork-7.0.0-11.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. I marked my patches obsolete because they are not what went in. I tested the package from testing and it works fine (in fact I'm running it now without any problems). redhat-artwork-7.0.0-11.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. Can you please apply the fix to devel too (now that we're probably going to still ship KWin v3 in F8)? |