Bug 2428466
| Summary: | Review Request: kraft - Handle your daily quotes and invoices in your small business | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | farchord, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Benson Muite
2026-01-10 14:49:26 UTC
Curious, is there a reason why you started using cmake() BRs and then switched to package names? I think it might be a good idea to reference all of the cmake BRs in the spec for futureproofing (In case the cmake modules get moved around for example). Also, you have cmake(Qt6Core) and qt6-qtbase-devel referenced which are the same thing. kf6-rpm-macros needs to be added as a BR too. While this isn't an official KDE project, you should probably also use %cmake_kf6 instead of %cmake Thanks for the feedback. Updated: spec: https://fed500.fedorapeople.org/kraft.spec srpm: https://fed500.fedorapeople.org/kraft-2.0.0-1.fc43.src.rpm plama-breeze-qt6 does not seem to have a CMake file nor a pkgconfig file: https://src.fedoraproject.org/rpms/plasma-breeze/blob/rawhide/f/plasma-breeze.spec Copr build: https://copr.fedorainfracloud.org/coprs/build/10065208 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2428466-kraft/fedora-rawhide-x86_64/10065208-kraft/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. spec: https://fed500.fedorapeople.org/kraft.spec srpm: https://fed500.fedorapeople.org/kraft-2.0.0-1.fc43.src.rpm [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/10082120 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2428466-kraft/fedora-rawhide-x86_64/10082120-kraft/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. spec: https://fed500.fedorapeople.org/kraft.spec srpm: https://fed500.fedorapeople.org/kraft-2.0.0-1.fc43.src.rpm Build fails with %cmake_kf6 so will use %cmake |