Bug 2429732

FTBFS in rawhide, due to -Werror

vsomeip-3.5.11/implementation/endpoints/src/local_tcp_client_endpoint_impl.cpp:215:44: error: ‘boost::asio::detail::wrapped_handler<boost::asio::io_context::strand, Handler, boost::asio::detail::is_continuation_if_running> boost::asio::io_context::strand::wrap(Handler) [with Handler = std::_Bind<void (vsomeip_v3::client_endpoint_impl<boost::asio::ip::tcp>::*(std::shared_ptr<vsomeip_v3::client_endpoint_impl<boost::asio::ip::tcp> >, std::_Placeholder<1>))(const boost::system::error_code&)>]’ is deprecated: Use boost::asio::bind_executor() [-Werror=deprecated-declarations]

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Taking ticket. Not sure how to fix yet.

The simplest hack would be to just add this before the error line:

// boost::asio::io_context::strand::wrap is deprecated
// and should be replaced with boost::asio::bind_executor
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"

That would only kick the can down the road, because Boost.Asio will remove the deprecated API eventually. But that would be a problem for another day.

Sigh, it's not that simple. After fixing a whole bunch of boost::asio deprecation warnings, it fails with this -Werror=array-bounds warning, due to a false positive regression in gcc-16:

/usr/include/c++/16/bits/shared_ptr_base.h:670:45: error: array subscript ‘std::_Sp_counted_ptr_inplace<vsomeip::message_impl, std::allocator<void>, __gnu_cxx::_S_atomic>[0]’ is partly outside array bounds of ‘unsigned char [48]’ [-Werror=array-bounds=]
  670 |       ~_Sp_counted_ptr_inplace() noexcept { }
      |                                             ^


THIS IS WHY YOU DON'T USE -Werror IN RPM BUILDS

I created https://src.fedoraproject.org/rpms/vsomeip3/pull-request/5 for the boost stuff I found so far.

(In reply to Jonathan Wakely from comment #4)
> The simplest hack would be to just add this before the error line:
> 
> // boost::asio::io_context::strand::wrap is deprecated
> // and should be replaced with boost::asio::bind_executor
> #pragma GCC diagnostic ignored "-Wdeprecated-declarations"

The pull request I created uses warning instead of ignored, as that means the warnings aren't completely suppressed, just no longer make fatal by -Werror

OK that was the last failure, so I patched around the the -Warray-bounds warning too.

The pull request on pagure should allow this to build now.

I thought I turned that off in the Makefiles previously but I think that patch died at some point. I think the `-Werror` comes from the automobile safety market they are in. I am a version behind upstream so will see if this is still broken ( I expect so.. I keep dealing with others who are JUST moving from Ubuntu2016 to 2018 ). 

Thank you for the patches. I was going to start working on these myself so I really appreciate it.

(In reply to Jonathan Wakely from comment #5)
> Sigh, it's not that simple. After fixing a whole bunch of boost::asio
> deprecation warnings, it fails with this -Werror=array-bounds warning, due
> to a false positive regression in gcc-16:
> 
> /usr/include/c++/16/bits/shared_ptr_base.h:670:45: error: array subscript
> ‘std::_Sp_counted_ptr_inplace<vsomeip::message_impl, std::allocator<void>,
> __gnu_cxx::_S_atomic>[0]’ is partly outside array bounds of ‘unsigned char
> [48]’ [-Werror=array-bounds=]
>   670 |       ~_Sp_counted_ptr_inplace() noexcept { }
>       |                                             ^


I think that warning is https://gcc.gnu.org/PR122197

I have built https://koji.fedoraproject.org/koji/taskinfo?taskID=141448501 which incorporates the fixes.