Bug 2430570
| Summary: | Review Request: ggml - Tensor library for machine learning | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Lent <lx> |
| Component: | Package Review | Assignee: | Peter Robinson <pbrobinson> |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, pbrobinson, tflink |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://ggml.ai/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alexander Lent
2026-01-17 05:56:15 UTC
Hm, this probably needs a conflicts with whisper.cpp <= 1.8.1 since it provides libggml.so with a higher soversion ... oops Spec URL: https://gist.github.com/xanderlent/55399e0be269e08dcce994de277b3ba4/raw/4e9dafba2e2c203a405003acf4011449decf3e66/ggml.spec SRPM URL: https://gist.github.com/xanderlent/55399e0be269e08dcce994de277b3ba4/raw/4e9dafba2e2c203a405003acf4011449decf3e66/ggml-0.9.5-1.fc44.src.rpm hm, llama.cpp <= b6153 also conflicts, and reminds me I need to build the python bindings, too... oh, hm, whisper.cpp and llama.cpp probably should have Conflicts: right now... oops Copr build: https://copr.fedorainfracloud.org/coprs/build/10032452 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430570-ggml/fedora-rawhide-x86_64/10032452-ggml/fedora-review/review.txt Found issues: - Unversioned so-files directly in %_libdir. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/10032451 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430570-ggml/fedora-rawhide-x86_64/10032451-ggml/fedora-review/review.txt Found issues: - Unversioned so-files directly in %_libdir. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I'll review, I was in the process of packaging this myself. (In reply to Alexander Lent from comment #3) > hm, llama.cpp <= b6153 also conflicts, and reminds me I need to build the > python bindings, too... > > oh, hm, whisper.cpp and llama.cpp probably should have Conflicts: right > now... oops Both of those now have _USE_SYSTEM_GGML options so if we coordinate with the maintainer with PRs to the package when we land this this package should just automatically be pulled in and likely can just avoid Conflicts. ollama also uses ggml but has prefixes, not sure if there's options there to build against a system ggml. IThanks for taking this review, it might be a little before I can do a second round; I'm going to try restructuring this package a bit like the proposal in https://src.fedoraproject.org/rpms/ollama/pull-request/7 which Tom has asked me to work on integrating there, once things are back under control again. |