Bug 2430650

Summary: Review Request: python-jack-client - JACK Audio Connection Kit (JACK) Client for Python
Product: [Fedora] Fedora Reporter: Erich Eickmeyer <erich>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: benson_muite, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://jackclient-python.rtfd.org
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-01-19 19:50:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2429022    
Attachments:
Description Flags
The .spec file difference from Copr build 10032442 to 10035990 none

Description Erich Eickmeyer 2026-01-17 23:46:02 UTC
Spec URL: https://raw.githubusercontent.com/eeickmeyer/python-jack-client-packaging/refs/heads/main/python-jack-client.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/10033229-python-jack-client/python-jack-client-0.5.5-1.fc44.src.rpm
Description: Python module that provides bindings for the JACK library.
The module is able to create audio input and output ports,
also provides the functionality to manage MIDI ports.

This package installs the library for Python.
Fedora Account System Username: eeickmeyer

Comment 1 Fedora Review Service 2026-01-18 03:05:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10032442
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430650-python-jack-client/fedora-rawhide-x86_64/10032442-python-jack-client/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Erich Eickmeyer 2026-01-18 04:16:08 UTC
A new run in COPR resulted in a successful build: https://copr.fedorainfracloud.org/coprs/eeickmeyer/Jam-Incoming/build/10032532/

Comment 3 Benson Muite 2026-01-18 04:30:34 UTC
Please update the spec file to use the current packaging guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

You might find pyp2spec helpful for this
https://packages.fedoraproject.org/pkgs/pyp2spec/pyp2spec/

If you wish to live at the bleeding edge of Python packaging, a
declarative build system is also in development and is documented
at:

https://src.fedoraproject.org/rpms/pyproject-rpm-macros

Comment 4 Erich Eickmeyer 2026-01-18 14:16:43 UTC
(In reply to Benson Muite from comment #3)
> Please update the spec file to use the current packaging guidelines:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

Done!

> You might find pyp2spec helpful for this
> https://packages.fedoraproject.org/pkgs/pyp2spec/pyp2spec/

It was useful, thanks!

> If you wish to live at the bleeding edge of Python packaging, a
> declarative build system is also in development and is documented
> at:
> 
> https://src.fedoraproject.org/rpms/pyproject-rpm-macros

Heh, not sure I want to go *that far*.

Either way, new copr build at https://copr.fedorainfracloud.org/coprs/eeickmeyer/Jam-Incoming/build/10033229/ that successfully built. I've updated the srpm link as well.

Comment 5 Benson Muite 2026-01-19 06:30:25 UTC
Please put updated links to spec file and srpm here rather than to a build repository on copr.

Comment 6 Erich Eickmeyer 2026-01-19 14:50:47 UTC
(In reply to Benson Muite from comment #5)
> Please put updated links to spec file and srpm here rather than to a build
> repository on copr.

Yep, I had done that and edited the original description. Here it is again:

Spec URL: https://raw.githubusercontent.com/eeickmeyer/python-jack-client-packaging/refs/heads/main/python-jack-client.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/10033229-python-jack-client/python-jack-client-0.5.5-1.fc44.src.rpm

Comment 7 Fedora Review Service 2026-01-19 19:47:59 UTC
Created attachment 2122781 [details]
The .spec file difference from Copr build 10032442 to 10035990

Comment 8 Fedora Review Service 2026-01-19 19:48:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10035990
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430650-python-jack-client/fedora-rawhide-x86_64/10035990-python-jack-client/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-jack-client
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/python-jack-client/diff.txt
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Erich Eickmeyer 2026-01-19 19:50:30 UTC
releng just unretired this for me, I guess we can close?

Comment 10 Fedora Update System 2026-01-19 21:55:33 UTC
FEDORA-2026-71c375ae85 (python-jack-client-0.5.5-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-71c375ae85

Comment 11 Fedora Update System 2026-01-20 01:59:25 UTC
FEDORA-2026-71c375ae85 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-71c375ae85`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-71c375ae85

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2026-01-22 01:08:11 UTC
FEDORA-2026-71c375ae85 (python-jack-client-0.5.5-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.