Bug 243076
Summary: | Review Request: reciteword - Recite Word Easily | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hu Zheng <zhu> | ||||
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | eng-i18n-bugs, petersen, zavandi | ||||
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | 0.8.3-3.fc7 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-06-27 03:54:50 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Hu Zheng
2007-06-07 07:25:36 UTC
It will be good to have source0 url using %{name} and %{version}. OK, fixed as the same file. Any more comments? Thank you! (In reply to comment #2) > OK, fixed as the same file. > Any more comments? Thank you! > yes I do have. I saw under /usr/share/reciteword/books/ directory many hidden files .dirname getting installed from rpm but rpmlint is complaining warning about that. Is that necessary or once package got installed and each time started they(.dirname files) will be created on fly? If yes it can be removed in SPEC. Created attachment 156976 [details]
Modified SPEC
You may like to use this SPEC file.
Add Changelog and give new updated links
Well, there is a reason for .dirname file. This file contain the local name(such as Chinese) of the directory, it is better don't make the dir have Chinese name directly, because UTF-8 file name have problem on windows platform after extract the .tar.bz2 file, so I save the dir name in this file, and choose .dirname to hide this. If hidden file is not good, I can fix this as change the file name to "dirname". Do you think this is necessay? To fix this won't take much time. I have created the new version according to your modification. The patch0 already modified the .desktop file, so desktop-file-install should be not necessay, but I added update-desktop-database. Here are the new files: http://reciteword.cosoft.org.cn/redhat/reciteword.spec http://reciteword.cosoft.org.cn/redhat/reciteword-0.8.3-2.fc7.src.rpm Thank you! Hi, Is this package have MIME type? Saw you included update-desktop-database scriptlet. Also if you look at http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef you will find above FC5+, you will not be required to have Requires(post): desktop-file-utils Requires(postun): desktop-file-utils Also I think its good to change the file name to "dirname". No, no MIME. update-desktop-database have function of update the .desktop cache too, right? OK, updated as the same files. New patch and the find script to fix the .dirname problem. Any more problem? If no, I think we can approve the review now? remove update-desktop-database it has nothing to do with .desktop cache updation but to update MIME file /usr/share/applications/mimeinfo.cache Done. As the same spec file. bump the release. I saw 2 times you used same release version and kindly submit each time download links to review package. http://reciteword.cosoft.org.cn/redhat/reciteword.spec http://reciteword.cosoft.org.cn/redhat/reciteword-0.8.3-2.fc7.src.rpm thanks for links Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMs. + source files match upstream. 5c7b106787f956ace8059f91bcec1836 reciteword-0.8.3.tar.bz2 9fb497b9f1c048aaf1ff16106a3e3ead reciteword-books-0.8.3.tar.bz2 f41d9dd162c4360924cfedb5cce3e5af reciteword-dicts-0.8.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exist. + no .la files. + no translations available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets used. + Desktop files installed correctly. + Requires: esound >= 0.2.28 gtk2 >= 2.2 libatk-1.0.so.0 libaudiofile.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.4) libcairo.so.2 libdl.so.2 libesd.so.0 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpng12.so.0 libpthread.so.0 librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH) + GUI App. APPROVED. New Package CVS Request ======================= Package Name: reciteword Short Description: Recite Word Easily Owners: zhu Branches: FC-6 F-7 EL-5 InitialCC: cvs done. Build succeeded at last. Thanks everyone! Done :) reciteword-0.8.3-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. $ reciteword RealPeopleTTS files not found! esd initialization failed,no sound will be play! Yeah, it's a great program! I'm sooo glad the spec file passed all the tests. Also, the fact that it can only be used by Chinese people I'm sure is an insignificant detail that didn't even deserve to be mentioned in the description of the package. I'll just have to download some TTS engine from some site (hope it's freeware, though), install esd instead of the outdated ALSA, learn Chinese, then I'll be on my way to use this fine piece of software to learn English pronunciation. Super duper! You can vist http://reciteword.cosoft.org.cn for more information, and you can find RealPeopleTTS there. It is better use reciteword in GNOME and enable esd by default in GNOME. Although you can run "esd &" before running reciteword too. There is a "en" skin too which provides English interface, although it is not very beautiful. I may add German support in the next verdsion :) Thank you for your support! Thanks, that information was helpful. But I think you should mention it some form of official documentation, because most Fedora users won't be able to use reciteword in its current form (and they won't post to bugzilla, either). Click the help button. |