Bug 2430763

[fedora-review-service-build]

Output of fedora-review:

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* GNU General Public
     License, Version 3", "GNU General Public License v3.0 or later", "GNU
     General Public License v3.0 only". 165 files have unknown license.
     Detailed output of licensecheck in
     /home/farchord/Documents/fedora/warehouse/2430763-warehouse/licensecheck.txt
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/zh_Hant,
     /usr/share/locale/zh_Hans, /usr/share/locale/zh_Hant/LC_MESSAGES,
     /usr/share/locale/zh_Hans/LC_MESSAGES
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/glib-2.0,
     /usr/share/locale/zh_Hant, /usr/share/locale/zh_Hant/LC_MESSAGES,
     /usr/share/glib-2.0/schemas, /usr/share/locale/zh_Hans/LC_MESSAGES,
     /usr/share/locale/zh_Hans
[ ]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 4386 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: warehouse-2.2.0-1.fc44.noarch.rpm
          warehouse-2.2.0-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp7echyqyy')]
checks: 32, packages: 2

warehouse.noarch: E: spelling-error ('Flatpak', 'Summary(en_US) Flatpak -> Flattop')
warehouse.noarch: E: spelling-error ('flatpak', '%description -l en_US flatpak -> flattop')
warehouse.noarch: E: spelling-error ('flatpaks', '%description -l en_US flatpaks -> flattops')
warehouse.src: E: spelling-error ('Flatpak', 'Summary(en_US) Flatpak -> Flattop')
warehouse.src: E: spelling-error ('flatpak', '%description -l en_US flatpak -> flattop')
warehouse.src: E: spelling-error ('flatpaks', '%description -l en_US flatpaks -> flattops')
warehouse.noarch: E: non-executable-script /usr/share/warehouse/src/const.py 644 /usr/bin/python3
warehouse.noarch: W: no-manual-page-for-binary warehouse
warehouse.noarch: E: incorrect-locale-subdir /usr/share/locale/zh_Hans/LC_MESSAGES/warehouse.mo
warehouse.noarch: E: incorrect-locale-subdir /usr/share/locale/zh_Hant/LC_MESSAGES/warehouse.mo
warehouse.noarch: E: explicit-lib-dependency libadwaita
 2 packages and 0 specfiles checked; 10 errors, 1 warnings, 7 filtered, 10 badness; has taken 0.3 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

warehouse.noarch: E: spelling-error ('Flatpak', 'Summary(en_US) Flatpak -> Flattop')
warehouse.noarch: E: spelling-error ('flatpak', '%description -l en_US flatpak -> flattop')
warehouse.noarch: E: spelling-error ('flatpaks', '%description -l en_US flatpaks -> flattops')
warehouse.noarch: E: non-executable-script /usr/share/warehouse/src/const.py 644 /usr/bin/python3
warehouse.noarch: W: no-manual-page-for-binary warehouse
warehouse.noarch: E: incorrect-locale-subdir /usr/share/locale/zh_Hans/LC_MESSAGES/warehouse.mo
warehouse.noarch: E: incorrect-locale-subdir /usr/share/locale/zh_Hant/LC_MESSAGES/warehouse.mo
warehouse.noarch: E: explicit-lib-dependency libadwaita
 1 packages and 0 specfiles checked; 7 errors, 1 warnings, 3 filtered, 7 badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/flattool/warehouse/archive/2.2.0/warehouse-2.2.0.tar.gz :
  CHECKSUM(SHA256) this package     : 4e6feb0fa82e5ab7ea74c22705cce5695b6c36a91da46e4c2ba0b962f53f66a0
  CHECKSUM(SHA256) upstream package : 4e6feb0fa82e5ab7ea74c22705cce5695b6c36a91da46e4c2ba0b962f53f66a0


Requires
--------
warehouse (rpmlib, GLIBC filtered):
    /usr/bin/python3
    flatpak-spawn
    gobject-introspection
    gtk4
    hicolor-icon-theme
    libadwaita



Provides
--------
warehouse:
    application()
    application(io.github.flattool.Warehouse.desktop)
    metainfo()
    metainfo(io.github.flattool.Warehouse.metainfo.xml)
    mimehandler(application/vnd.flatpak)
    mimehandler(application/vnd.flatpak.ref)
    mimehandler(application/vnd.flatpak.repo)
    mimehandler(x-scheme-handler/flatpak)
    warehouse



Diff spec file in url and in SRPM
---------------------------------
--- /home/farchord/Documents/fedora/warehouse/2430763-warehouse/srpm/warehouse.spec     2026-01-19 12:54:18.960055976 -0500
+++ /home/farchord/Documents/fedora/warehouse/2430763-warehouse/srpm-unpacked/warehouse.spec    2026-01-18 19:00:00.000000000 -0500
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.3)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %global app_id  io.github.flattool.Warehouse
 
@@ -70,3 +80,6 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Mon Jan 19 2026 John Doe <packager> - 2.2.0-1
+- Uncommitted changes
+## END: Generated by rpmautospec


Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2430763
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: C/C++, PHP, Haskell, R, SugarActivity, Ocaml, Perl, fonts, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

I see two things that would potentially need to be reported upstream:

warehouse.noarch: E: non-executable-script /usr/share/warehouse/src/const.py 644 /usr/bin/python3 (Not sure why that's there... can it maybe simply get removed?
warehouse.noarch: E: incorrect-locale-subdir /usr/share/locale/zh_Hans/LC_MESSAGES/warehouse.mo
warehouse.noarch: E: incorrect-locale-subdir /usr/share/locale/zh_Hant/LC_MESSAGES/warehouse.mo (This would need to be checked as to why they are using a bad locale)
warehouse.noarch: E: explicit-lib-dependency libadwaita (That's probably fine)

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10035980
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430763-warehouse/fedora-rawhide-x86_64/10035980-warehouse/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10035981
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430763-warehouse/fedora-rawhide-x86_64/10035981-warehouse/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.