Bug 243087
Summary: | Conflict between use of local timestamps and RFC3659 MDTM usage | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ted Rule <ejtr> | ||||
Component: | vsftpd | Assignee: | Martin Nagy <mnagy> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | |||||
Severity: | low | Docs Contact: | |||||
Priority: | low | ||||||
Version: | rawhide | CC: | cra, hripps, mbarabas, mnagy | ||||
Target Milestone: | --- | Keywords: | Patch | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-12-04 12:39:03 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Ted Rule
2007-06-07 09:15:26 UTC
Created attachment 156436 [details]
Patch to add a "log_localtime" option to vsftpd
I believe this issue still applies to vsftpd in Fedora 7 and 8. Can the submitter please update this and change the version to "devel". Thanks. Within postlogin.c, the handle_mdtm() function in the latest devel version of vsftpd.RPM does indeed still appear to exhibit the problem, as in: From: ../download.fedora.redhat.com/pub/fedora/linux/development/source/SRPMS/vsftpd-2.0.5-19.fc8.src.rpm handle_mdtm() ... str_alloc_text(&s_mdtm_res_str, vsf_sysutil_statbuf_get_numeric_date( s_p_statbuf, tunable_use_localtime)); ... Consequently, I'll amend the status from FC6 to devel to reflect the desire to fix this in FC8. Thanks for the patch, but I decided to just revert the changes made in Bug #143687 This means that use_localtime now does not have any affect on logging (logs will be in local time). My reasons are, that there is already too much options in vsftpd and I don't consider this change to be so drastic that we need backward compatibility. Also, this way, we are more closer to the upstream. So presumably means that the following applies: Pre-Bugzilla 143687: Logs timestamp - always UTC LS response listing - toggled by use_localtime option MDTM response - toggled by use_localtime option Current RPM: Logs timestamp - toggled by use_localtime option LS response listing - toggled by use_localtime option MDTM response - toggled by use_localtime option My patch - Bugzilla 243087: Logs timestamp - toggled by my log_localtime option LS response listing - toggled by use_localtime option MDTM response - toggled by use_localtime option RedHat response to Bugzlla 2243087: Logs timestamp - always local timestamp LS response listing - toggled by use_localtime option MDTM response - toggled by use_localtime option Seems fair - the backwards compatibility effect is thereby only to upset those who rely on a UTC timestamp in the logs, which is probably a very small subset; I would guess that most people enabled use_localtime=yes to get the logging "correct" and somewhat ignored the downside of "broken" non-UTC timestamps in th LS and MDTM responses. You are correct, except for one thing: Pre-Bugzilla 143687 Logs timestamp - always local timestamp I know that the reporter of Bug #143687 stated otherwise, but all I did was that I removed the patch and it works just fine for me. So I guess that he just misconfigured something. Fixed in vsftpd-2.0.5-21.fc9 |