Bug 2434112

Summary: Review Request: rust-cond_sync - Hides the boilerplate code needed with std::sync::Condvar
Product: [Fedora] Fedora Reporter: Gwyn Ciesla <gwync>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: code, package-review, troels
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/cond_sync
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2434118    

Description Gwyn Ciesla 2026-01-28 18:41:37 UTC
SRPM:https://fedorapeople.org/~limb/review/rust-cond_sync/rust-cond_sync-0.2.1-1.fc44.src.rpm
SPEC:https://fedorapeople.org/~limb/review/rust-cond_sync/rust-cond_sync.spec

Description:
Hides the boilerplate code needed with std::sync::Condvar.

Comment 1 Fedora Review Service 2026-01-28 21:56:05 UTC
There seems to be some problem with the following file.
SRPM URL: https://fedorapeople.org/~limb/review/rust-cond_sync/rust-cond_sync-0.2.1-1.fc44.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2026-03-02 08:06:24 UTC
The repository link in Cargo.toml is broken; I found the correct repository and filed https://github.com/emabee/rust-cond_sync/pull/1 to fix it. You might consider correcting the repository link downstream with "rust2rpm -p".

Both MIT and Apache-2.0 license texts are missing from the published crate and the upstream repository. Both licenses require the text to be distributed, so you have to actually fix this. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text, and try working with upstream first.

Comment 4 Fedora Review Service 2026-03-04 09:06:08 UTC
There seems to be some problem with the following file.
SRPM URL: https://fedorapeople.org/~limb/review/rust-cond_sync/rust-cond_sync-0.2.1-1.fc45.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fedora Review Service 2026-03-09 21:44:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10205132
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2434112-rust-cond_sync/fedora-rawhide-x86_64/10205132-rust-cond_sync/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.