Bug 2434123

There seems to be some problem with the following file.
SRPM URL: https://fedorapeople.org/~limb/review/rust-string-cases/rust-string-cases-0.2.0-1.fc44.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> # FIXME: no license files detected

You have to actually fix this. The MIT license does require the text (copyright and permission statements) to be distributed. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text. Try working with upstream first.

Since the README.md is included as a Rust documentation string,

> #![doc = include_str!("./README.md")]

it should not be packaged as documentation, because compilation of the crate will fail without it. This is a subtle issue, easy to miss and unlikely to cause problems in practice since Rust library packages are generally only useful for building other Fedora packages, but strictly speaking you should do something about it. You can try something like this in rust2rpm.toml

[package]
doc-files.exclude = [
    # This file is included as a documentation string in the library, so
    # compilation fails if it is not present. It therefore must not be marked
    # as documentation, because packages should be equally useful when their
    # documentation is not installed.
    "README.md",
]

To being with:

https://github.com/kaleidawave/string-cases/issues/2

I tried the rust2rpm.toml suggesting but it doesn't seem to work.

(In reply to Gwyn Ciesla from comment #5)
> I tried the rust2rpm.toml suggesting but it doesn't seem to work.

Hmm, I just tried copying everything starting with [package] from https://bugzilla.redhat.com/show_bug.cgi?id=2434123#c3 into a rust2rpm.toml file in an empty directory, then running “rust2rpm -I string-cases”, and it worked exactly as expected, generating a spec file like the current submission but without the line “%doc %{crate_instdir}/README.md”. What does it do instead for you?

(In reply to Gwyn Ciesla from comment #4)
> https://github.com/kaleidawave/string-cases/issues/2

Upstream fixed this in https://github.com/kaleidawave/string-cases/commit/787ef44c626edc30e1aaf420da5eb14fca0f491a. You would be well-justified in using the new LICENCE file as an additional source (https://github.com/kaleidawave/string-cases/raw/787ef44c626edc30e1aaf420da5eb14fca0f491a/LICENCE) and patching it in using something similar to https://src.fedoraproject.org/rpms/rust-quote-use-macros/blob/rawhide/f/rust2rpm.toml.

(In reply to Ben Beasley from comment #6)
> (In reply to Gwyn Ciesla from comment #5)
> > I tried the rust2rpm.toml suggesting but it doesn't seem to work.
> 
> Hmm, I just tried copying everything starting with [package] from
> https://bugzilla.redhat.com/show_bug.cgi?id=2434123#c3 into a rust2rpm.toml
> file in an empty directory, then running “rust2rpm -I string-cases”, and it
> worked exactly as expected, generating a spec file like the current
> submission but without the line “%doc %{crate_instdir}/README.md”. What does
> it do instead for you?

That. I was looking for an %exclude line because I'm as new to rust packaging as I am to rust. Thank you. :)

SRPM:https://fedorapeople.org/~limb/review/rust-string-cases/rust-string-cases-0.2.0-1.fc45.src.rpm
SPEC:https://fedorapeople.org/~limb/review/rust-string-cases/rust-string-cases.spec

Thank you. Required a minor tweak due to upstream spelling.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10189712
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2434123-rust-string-cases/fedora-rawhide-x86_64/10189712-rust-string-cases/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.