Bug 2435920

Amazing addition to Fedora. Let's work on it.

Ok, looks good but I still have some proposals.

* Remove pushd build..popd - out %cmake and %ctest macros already changing working directory to "redhat-linux-build" so it won;'t mess with source code.
* Remove "ls && ls contrib" leftovers
* Instead of creating user and group in old-fashioned way consider using systemd for that. See for example - https://src.fedoraproject.org/rpms/mpdscribble/blob/rawhide/f/mpdscribble.spec#_44

Updated. 

(In reply to Peter Lemenkov from comment #2)
> Ok, looks good but I still have some proposals.
> 
> * Remove pushd build..popd - out %cmake and %ctest macros already changing
> working directory to "redhat-linux-build" so it won;'t mess with source code.

Build fails without entering build directory which contains cmake files

> * Remove "ls && ls contrib" leftovers

Done. Thanks.

> * Instead of creating user and group in old-fashioned way consider using
> systemd for that. See for example -
> https://src.fedoraproject.org/rpms/mpdscribble/blob/rawhide/f/mpdscribble.
> spec#_44

 Done. Thanks.


spec: https://fed500.fedorapeople.org/i2pd.spec
srpm: https://fed500.fedorapeople.org/i2pd-2.58.0-1.fc43.src.rpm

Few notes.

* Plenty of warning like this one:

```
In file included from /builddir/build/BUILD/i2pd-2.58.0-build/i2pd-2.58.0/build/../libi2pd/LeaseSet.h:19,
                 from /builddir/build/BUILD/i2pd-2.58.0-build/i2pd-2.58.0/build/../libi2pd/I2NPProtocol.h:22,
                 from /builddir/build/BUILD/i2pd-2.58.0-build/i2pd-2.58.0/build/../libi2pd/Garlic.h:20,
                 from /builddir/build/BUILD/i2pd-2.58.0-build/i2pd-2.58.0/build/../libi2pd/RouterContext.h:20,
                 from /builddir/build/BUILD/i2pd-2.58.0-build/i2pd-2.58.0/daemon/UPnP.cpp:15:
/builddir/build/BUILD/i2pd-2.58.0-build/i2pd-2.58.0/build/../libi2pd/Timestamp.h:57:53: warning: ‘boost::asio::deadline_timer’ is deprecated: Use system_timer [-Wdeprecated-declarations]
   57 |                         boost::asio::deadline_timer m_Timer;
```

Looks very straighforward to fix so if you have a spare time then report it upstream or either try fixning it by yourself and propose a PR. Not a blocker.

* Nobody owns /usr/share/i2pd. Please add it to %files section.

* Plenty of rpmlint issues (see below). Please address them.

I can't spot any other issues so here is my formal

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
- Dist tag is present.


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license (BSD 3-Clause).
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/i2pd. See my remark above.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/i2pd. See my remark above.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format (%autochangelog).
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[-]: Not a GUI application.
[-]: No development files provided (standalone app).
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: The package is not a rename of another package.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: No extremely large documentation files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
     systemd_postun in %postun for Systemd service files.
     Note: Systemd service file(s) in i2pd
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: I did not test if the package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources weren't verified with gpgverify.
[?]: I did not test if the package should compile and build into binary 
     rpms on all supported architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 6.6 starting (python version = 3.14.2, NVR = mock-6.6-1.fc43), args: /usr/libexec/mock/mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --resultdir=/home/petro/rpmbuild/SPECS/2435920-i2pd/results install /home/petro/rpmbuild/SPECS/2435920-i2pd/results/i2pd-2.58.0-1.fc44.x86_64.rpm /home/petro/rpmbuild/SPECS/2435920-i2pd/results/i2pd-debuginfo-2.58.0-1.fc44.x86_64.rpm /home/petro/rpmbuild/SPECS/2435920-i2pd/results/i2pd-debugsource-2.58.0-1.fc44.x86_64.rpm
Start(bootstrap): init plugins
INFO: selinux enabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Mock Version: 6.6
INFO: Mock Version: 6.6
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: Package manager dnf5 detected and used (fallback)
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
INFO: Package manager dnf5 detected and used (direct choice)
Finish: chroot init
INFO: installing package(s): /builddir/i2pd-2.58.0-1.fc44.x86_64.rpm /builddir/i2pd-debuginfo-2.58.0-1.fc44.x86_64.rpm /builddir/i2pd-debugsource-2.58.0-1.fc44.x86_64.rpm
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 62a2f85a97b244bc9840495e2ca1a777 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.mrbz648w:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 44 install /builddir/i2pd-2.58.0-1.fc44.x86_64.rpm /builddir/i2pd-debuginfo-2.58.0-1.fc44.x86_64.rpm /builddir/i2pd-debugsource-2.58.0-1.fc44.x86_64.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts



Rpmlint
-------
Checking: i2pd-2.58.0-1.fc44.x86_64.rpm
          i2pd-2.58.0-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp0y8hfou0')]
checks: 32, packages: 2

i2pd.src: E: spelling-error ('filesharing', '%description -l en_US filesharing -> file sharing, file-sharing, files haring')
i2pd.x86_64: E: spelling-error ('filesharing', '%description -l en_US filesharing -> file sharing, file-sharing, files haring')

^^^ false positive

i2pd.x86_64: W: non-standard-uid /var/lib/i2pd i2pd
i2pd.x86_64: W: non-standard-uid /var/log/i2pd i2pd
i2pd.x86_64: W: non-standard-gid /var/lib/i2pd i2pd
i2pd.x86_64: W: non-standard-gid /var/log/i2pd i2pd
i2pd.x86_64: E: non-standard-dir-perm /var/log/i2pd 700

^^^ false positive

i2pd.x86_64: W: non-conffile-in-etc /etc/i2pd/tunnels.conf.d/README

^^^ false positive. Should be here.

i2pd.x86_64: W: non-conffile-in-etc /etc/logrotate.d/i2pd

^^^ Should it be marked as config?

i2pd.spec:24: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24)

^^^ Please fix this.

i2pd.x86_64: E: logrotate-log-dir-not-packaged "/var/log/i2pd


^^^ Please fix this.

i2pd.x86_64: E: file-parent-ownership-mismatch Path "/var/lib/i2pd/certificates" owned by "root" is stored in directory owned by "i2pd"

^^^ please fix that. It looks like unreadable file for me.

i2pd.x86_64: W: conffile-without-noreplace-flag /etc/i2pd/subscriptions.txt

^^^ this one is supposed to be kept unchanged by user.

 2 packages and 0 specfiles checked; 5 errors, 8 warnings, 9 filtered, 5 badness; has taken 0.6 s 


Source checksums
----------------
https://github.com/PurpleI2P/i2pd/archive/2.58.0/i2pd-2.58.0.tar.gz :
  CHECKSUM(SHA256) this package     : 5ff650c6da8fda3522c10ec22889a7fd1c6b5d1af42c24531d84c36f6cc49019
  CHECKSUM(SHA256) upstream package : 5ff650c6da8fda3522c10ec22889a7fd1c6b5d1af42c24531d84c36f6cc49019


Requires
--------
i2pd (rpmlib, GLIBC filtered):
    /bin/sh
    config(i2pd)
    group(i2pd)
    libboost_program_options.so.1.90.0()(64bit)
    libc.so.6()(64bit)
    libcrypto.so.3()(64bit)
    libcrypto.so.3(OPENSSL_3.0.0)(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libi2pd.so()(64bit)
    libi2pdclient.so()(64bit)
    libi2pdlang.so()(64bit)
    libm.so.6()(64bit)
    libminiupnpc.so.21()(64bit)
    libssl.so.3()(64bit)
    libssl.so.3(OPENSSL_3.0.0)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    logrotate
    rtld(GNU_HASH)
    systemd
    user(i2pd)



Provides
--------
i2pd:
    config(i2pd)
    group(i2pd)
    i2pd
    i2pd(x86-64)
    user(i2pd)



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2435920
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Ocaml, SugarActivity, fonts, Python, Java, Haskell, R, PHP, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH