Bug 243642
| Summary: | Review Request: schroedinger - Portable libraries for the high quality Dirac video codec | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeffrey C. Ollie <jeff> |
| Component: | Package Review | Assignee: | David Nielsen <gnomeuser> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kwizart |
| Target Milestone: | --- | Flags: | gnomeuser:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-20 17:25:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jeffrey C. Ollie
2007-06-11 06:17:52 UTC
Yeah that will teach me to search _before_ packaging something, ah well your spec is a bit more correct than mine anyways. I'll do the review once I unbork mock. At a casual glance though it looks to be in great shape and it compiles beautifully on my F8 x86_64 box. David, are you reviewing this? If so, please set fedora-review to '?'. GOOD:
- rpmlint is silent
- Follows naming guidelines
- %{name} matches base package
- Meets packaging guidelines
- License is OSI approved or compatible
- %doc's all required files
- SPEC is in US English
- SPEC is both beautiful and fully readable
- source matches upstream release
- Compile tested fine on x86_64
- All BuildRequires present
- Locale handled correctly
- Owns all files and directories
- ldconfig called in both post and postun
- Appears relocatable
- No duplicate entries in %files
- all %files sections contain %defattr and permissions appear correct
- Contains %clean and removes buildroot
- consistent use of macros
- package contains actual code
- runs without documentation
- Headers are in -devel
- library files with a suffix are in -devel
- -devel requires %{name} = %{version}-%{release}
- no -la files
- does not own files or directories already owned by other packages
- cleans out buildroot before install
- SPEC is valid UTF-8
BAD:
- License field should read LGPL/MIT/MPL as reported by upstream
- -devel package must Requires: pkgconfig as it contains a .pc file
APPROVED, just fix the license field and the Requires before checking this in.
Thank you, if you need a comaintainer for those vacation times and such I'll
happily help out.
Thanks for the review! I've fixed the issued you noticed in my local copy and will upload that... New Package CVS Request ======================= Package Name: schroedinger Short Description: Portable libraries for the high quality Dirac video codec Owners: jeff, david Branches: devel, F-7, FC-6 InitialCC: cvs done. Packages imported and built. Can you tell me why this package do not BuildRequires dirac-devel ? (In reply to comment #7) > Can you tell me why this package do not BuildRequires dirac-devel ? Because schroedinger doesn't use the dirac libraries, it's a complete re-implementation. Package Change Request ====================== Package Name: schroedinger New Branches: el5 el6 Owners: jcollie kwizart We need an ack from the primary maintainer here. +1 from me! Git done (by process-git-requests). |