Bug 2436975

Summary: Review Request: rocm-filesystem - ROCm directories
Product: [Fedora] Fedora Reporter: Tom.Rix
Component: Package ReviewAssignee: Miroslav Suchý <msuchy>
Status: RELEASE_PENDING --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: alexjnewt, msuchy, package-review, rocm-packagers-sig
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: msuchy: fedora-review+
Hardware: Unspecified   
OS: Linux   
URL: https://fedoraproject.org
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tom.Rix 2026-02-04 23:18:30 UTC 
Spec URL: https://trix.fedorapeople.org/rocm-filesystem.spec
SRPM URL: https://trix.fedorapeople.org/rocm-filesystem-7.2.0-1.fc44.src.rpm

This package moves the non compiler directories out of rocm-llvm-filesystems
and into its own package.

Reproducible: Always
Comment 1 Fedora Review Service 2026-02-04 23:21:03 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10094680
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2436975-rocm-filesystem/fedora-rawhide-x86_64/10094680-rocm-filesystem/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Miroslav Suchý 2026-02-05 09:21:15 UTC 
> %description
> %{summary}

Hmm, you can do better :)

> License:        MIT

This is unlikely to be true, as there is nothing to license. But there are other *filesystem packages that uses something else than LicenseRef-Fedora-Public-Domain, so I will not block on this.

> %dir %{_libdir}/rocm/gfx8
> %dir %{_libdir}/rocm/gfx8/bin
> %dir %{_libdir}/rocm/gfx8/include
> %dir %{_libdir}/rocm/gfx8/lib
> %dir %{_libdir}/rocm/gfx8/lib/cmake
> %dir %{_libdir}/rocm/gfx9
...

You know you can use globs to make your life easier, right? But as that is your preference, I will not block on this.

The package is

APPROVED
Comment 3 Tom.Rix 2026-02-05 16:13:05 UTC 
Thanks!

The license of MIT was choose because that is the default Fedora license.
The only source for the project is the specfile, which explicitly carries this license.
Comment 4 Fedora Admin user for bugzilla script actions 2026-02-05 16:14:43 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/rocm-filesystem