Bug 2437215

Summary:	Review Request: rubygem-chef-utils - A set of convenience functions for various libraries and utilities in the Chef ecosystem.
Product:	[Fedora] Fedora	Reporter:	Phil Dibowitz <phil>
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	RELEASE_PENDING ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	davide, package-review
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2437493

Description Phil Dibowitz 2026-02-06 00:21:45 UTC

Spec URL: https://copr-dist-git.fedorainfracloud.org/packages/jaymzh/rubygem-chef-utils/rubygem-chef-utils.git/plain/rubygem-chef-utils.spec
SRPM URL: https://phildev.net/chef-utils/rubygem-chef-utils-19.1.164-1.fc41.src.rpm
Description: A set of convenience functions for various libraries and utilities in the Chef ecosystem.
Fedora Account System Username: jaymzh

Comment 1 Fedora Review Service 2026-02-06 00:23:44 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10098020
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2437215-rubygem-chef-utils/fedora-rawhide-x86_64/10098020-rubygem-chef-utils/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Phil Dibowitz 2026-02-06 00:48:27 UTC

The builds failed, but I suspect that's due to the mass rebuild and koji being unavailable.

Comment 3 Phil Dibowitz 2026-02-06 21:15:08 UTC

[fedora-review-service-build]

BTW, builds that worked now that COPR is fixed: https://copr.fedorainfracloud.org/coprs/jaymzh/rubygem-chef-utils/build/10100996/

Comment 4 Davide Cavalca 2026-02-10 23:55:55 UTC

Taking this review

Comment 5 Davide Cavalca 2026-02-11 00:44:17 UTC

> Release: 1%{?dist}

Consider using rpmautospec given that this is a new package

> # Automatically converted from old format: ASL 2.0 - review is highly recommended.
> License: Apache-2.0

Audit that the license is actually correct and drop the comment if it is

> %description

This needs to be wrapped to 80 columns

> %check

You need to add the stuff you're using to buildrequires (tar, grep, xargs (which iirc comes from findutils or the like?))

> %doc %{gem_instdir}/LICENSE

This needs to be %license

Comment 6 Phil Dibowitz 2026-02-11 18:58:47 UTC

Thanks, all done.

New builds: https://copr.fedorainfracloud.org/coprs/jaymzh/rubygem-chef-utils/build/10117282/

Same URLs for spec and SRPM have been updated to new files.

Comment 7 Davide Cavalca 2026-02-11 22:24:53 UTC

Package was generated with gem2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the gem is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with the Packaging Guidelines

Package APPROVED.

Comment 8 Fedora Admin user for bugzilla script actions 2026-02-12 00:19:40 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-chef-utils