Bug 243733

Summary:	Review Request: perl-Time-Duration - Rounded or exact English expression of durations
Product:	[Fedora] Fedora	Reporter:	Jeffrey C. Ollie <jeff>
Component:	Package Review	Assignee:	Ruben Kerkhof <ruben>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ruben
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-07-01 20:44:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeffrey C. Ollie 2007-06-11 15:37:40 UTC

Spec URL: http://search.cpan.org/dist/Time-Duration/
SRPM URL: http://search.cpan.org/CPAN/authors/id/A/AV/AVIF/Time-Duration-%{version}.tar.gz
Description: 

This module provides functions for expressing durations in rounded or
exact terms.

Comment 1 Ruben Kerkhof 2007-07-01 19:41:23 UTC

Can you please provide correct urls to the specfile and the srpm?

Comment 2 Jeffrey C. Ollie 2007-07-01 20:15:06 UTC

Spec: http://repo.ocjtech.us/misc/fedora/6/SRPMS/perl-Time-Duration-1.04-1.fc6.spec
SRPM:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/perl-Time-Duration-1.04-1.fc6.src.rpm

Boy, I must have been half asleep when I posted those other urls...

Comment 3 Ruben Kerkhof 2007-07-01 20:28:53 UTC

Ah, thanks

Review for release 1:
* RPM name is OK
* Source Time-Duration-1.04.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* Checks are present and run successfully
* I wrote a small test script, and functionality is ok.

Needs work:
* BuildRequires: perl should not be included
  (wiki: PackagingGuidelines#Exceptions)

Comment 4 Ruben Kerkhof 2007-07-01 20:32:51 UTC

Hi Jeffrey,

It looks like this review is a duplicate of #242311
Maybe you and Marc can co-maintain this package?

Comment 5 Jeffrey C. Ollie 2007-07-01 20:44:49 UTC

I'll defer to Marc to get the package reviewed and voluteer my services as
co-maintainer.

*** This bug has been marked as a duplicate of 242311 ***