Bug 2437604
| Summary: | Review Request: kmonad - Advanced keyboard remapping utility | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | solomoncyj |
| Component: | Package Review | Assignee: | Jens Petersen <petersen> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | haskell-devel, package-review |
| Target Milestone: | --- | Flags: | petersen:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://hackage.haskell.org/package/kmonad | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-02-19 01:32:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
solomoncyj
2026-02-08 12:01:07 UTC
Spec URL: https://solomoncyj.fedorapeople.org/reviews/kmonad/kmonad.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/kmonad/kmonad-0.4.4-1.fc43.src.rpm - spec file generated by cabal-rpm-2.3.0 Copr build: https://copr.fedorainfracloud.org/coprs/build/10104593 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2437604-ghc-kmonad/fedora-rawhide-x86_64/10104593-ghc-kmonad/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/10104594 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2437604-kmonad/fedora-rawhide-x86_64/10104594-kmonad/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package has .a files: ghc-kmonad-devel, ghc-kmonad-prof. Illegal package name: ghc-kmonad-prof. Does not provide -static: ghc-kmonad-prof. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Overall this looks good.
(Btw I am going to add -prof-static provides to cabal-rpm in the following release.)
I checked the upstream git submodules but they are only for macos, so I think they can be ignored here.
I think the unit tests could be enabled: cabal-rpm can do that - you might need to install ghc-hspec-devel.
Also the systemd unit should live under %{_unitdir} (not /etc/).
(Arguably it might be more consistent to take the systemd file from the release tag, though it hasn't changed since.)
(It wouldn't hurt if upstream included the file in the tarball, though I don't think it's a blocker.)
Further the systemd unit should live in the main kmonad package (it doesn't pull in ghc-kmonad).
You can add `doc/quick-reference.md` to the kmonad %doc's I think, maybe also `keymap/tutorial.kbd`.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=142110958 Actually wondering if the systemd unit should be a user unit rather than system? System, it needs to reed device files Spec URL: https://solomoncyj.fedorapeople.org/reviews/kmonad/kmonad.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/kmonad/kmonad-0.4.4-1.fc43.src.rpm - spec file generated by cabal-rpm-2.3.0 I think you broke the build with:
-mkdir -p %{buildroot}/etc/systemd/system/
-cp %{S:1} %{buildroot}/etc/systemd/system/
+cp %{S:1} %{buildroot}/%{_unitdir}
The directory still needs to be created: if you don't want to create it separately
you could use say
install -Dp -m 0644 -t %{buildroot}/%{_unitdir} %{S:1}
Otherwise the package looks fine to me:
- MIT license (most of the src files are tagged)
- complies with Haskell Packaging guides
- cabal-rpm spec file with small tweaks
I tested it lightly in a VM with the following "test.kbd" config file:
```
(defcfg
input (device-file "/dev/input/event1")
output (uinput-sink "KMonad-Test-Device")
fallthrough true
allow-cmd false
)
(defsrc
caps
)
(deflayer default
esc
)
```
using both `sudo kmonad test.kbd` and `systemctl start kmonad@test` (for `/etc/kmonad/test.kbd`)
Package is APPROVED
Please fix the above minor build issue when importing :)
The Pagure repository was created at https://src.fedoraproject.org/rpms/kmonad https://pagure.io/releng/fedora-scm-requests/issue/81096 https://pagure.io/releng/fedora-scm-requests/issue/81097 https://pagure.io/releng/fedora-scm-requests/issue/81098 FEDORA-2026-89de5f9d29 (kmonad-0.4.4-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2026-89de5f9d29 FEDORA-2026-89de5f9d29 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-89de5f9d29 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-89de5f9d29 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-89de5f9d29 (kmonad-0.4.4-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2026-b2c9a05665 (kmonad-0.4.4-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-b2c9a05665 FEDORA-2026-7cf9b2ff84 (kmonad-0.4.4-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-7cf9b2ff84 FEDORA-2026-b2c9a05665 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-b2c9a05665 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-b2c9a05665 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-7cf9b2ff84 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-7cf9b2ff84 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-7cf9b2ff84 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-7cf9b2ff84 (kmonad-0.4.4-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2026-b2c9a05665 (kmonad-0.4.4-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. |