Bug 2439346
| Summary: | Review Request: danksearch - Indexed filesystem search in GO | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Neal Gompa <ngompa13> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-02-13 17:52:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2439344 | ||
|
Description
Neal Gompa
2026-02-12 15:37:41 UTC
- You're missing correct LDFLAGS: https://github.com/AvengeMedia/danksearch/blob/master/Makefile#L14-L18 Add this after GO111MODULE line: export GO_LDFLAGS="-X main.commit=fedora \ -X main.Version=%{version} \ -X main.buildTime=$(date -d "@${SOURCE_DATE_EPOCH}" +%Y-%m-%d_%H:%M:%S)" You should replace commit=Fedora with a proper hash as desribed in the Makefile, but as that makes automating updates with Packit more complex having a static string is not the worst idea. - go-vendor-tools > Source2: %{name}-go-vendor-tools.toml I would suggest to drop the %{name} prefix before importing to follow the standard in the rest of the packages until prefixing is included as an option for the tooling. Not required as part of the review. Spec URL: https://download.copr.fedorainfracloud.org/results/ngompa/DankMiracleDev/fedora-44-x86_64/10127769-danksearch/danksearch.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ngompa/DankMiracleDev/fedora-44-x86_64/10127769-danksearch/danksearch-0.1.2-1.fc44.src.rpm Incorporated requested fixes. Golang Package Review
==============
This package was generated using go2rpm and Go Vendor Tools, which simplifies
the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.
- [x] GO_LDFLAGS are set correctly.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance. Check https://fedora.gitlab.io/sigs/go/go-vendor-tools/scenarios/#packit
The Pagure repository was created at https://src.fedoraproject.org/rpms/danksearch Built in F44+. |