Bug 244123
| Summary: | Review Request: cvsplot - Collect statistics from CVS controlled files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marek Mahut <mmahut> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-23 00:49:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marek Mahut
2007-06-13 22:35:28 UTC
> Patch0: %{name}-%{version}.gnuplot.patch
Please do not use macros in patch names. Thier names should reflect the release
they have been added in, and thus never change. Your package would break if you
bumped a version number.
On the other side, you could have happily used the macros for the Source file.
Thank you, fixed. Files are updated, please double-check. cvsplot used to be in extras until FC5, is there a reason why we are starting a new review? https://admin.fedoraproject.org/pkgdb/packages/name/cvsplot Gianluca, We are reviewing basicaly new spac file for this package. I think it's the best to do for 3 release old package. Let me know if you don't agree. * source files match upstream:
MD5: 50315fad42d7ca5f94ccdd4f5d25ee03 cvsplot-1.7.4.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present and correctly used.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package installs properly
* debuginfo is not present as this is a perl package
* rpmlint is silent.
* final provides and requires are sane.
* %check is not present; no test suite upstream.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
Package Change Request ====================== Package Name: cvsplot New Branches: devel Owner: mmahut After discussion with Nigel Jones, I'm submiting new request. Package Change Request ====================== Package Name: cvsplot New Branches: EL-4 EL-5 FC-6 F-7 devel Owner: mmahut (In reply to comment #4) > Gianluca, > > We are reviewing basicaly new spac file for this package. I think it's the best > to do for 3 release old package. Let me know if you don't agree. No problems here. I just wanted to make sure you was aware of that. cvs branched, package un-orphaned. package build. |