Bug 244222
Summary: | Review Request: perl-CGI-FastTemplate - Perl extension for managing templates, and performing variable interpolation | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jeffrey C. Ollie <jeff> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | ktdreyer |
Target Milestone: | --- | Flags: | j:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-06-20 17:20:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jeffrey C. Ollie
2007-06-14 15:53:40 UTC
Spec URL: http://repo.ocjtech.us/misc/fedora/development/SRPMS/perl-CGI-FastTemplate-1.09-2.fc8.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/development/SRPMS/perl-CGI-FastTemplate-1.09-2.fc8.src.rpm Updated BR's and license. Not much to say here; builds fine and rpmlint is quiet. I guess if I really wanted to pick nits, there's a comma fault in Summary. * source files match upstream: 7d9d6b57bef2c3a33142c4cf0ca07d8801575e53b7f054b83df9f616bd2a7773 CGI-FastTemplate-1.09.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(CGI::FastTemplate) perl-CGI-FastTemplate = 1.09-2.fc8 = perl(:MODULE_COMPAT_5.8.8) perl(strict) * %check is present and all tests pass: All tests successful. Files=5, Tests=10, 0 wallclock secs ( 0.05 cusr + 0.05 csys = 0.10 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Thanks for the review! New Package CVS Request ======================= Package Name: perl-CGI-FastTemplate Short Description: Perl extension for managing templates and performing variable interpolation Owners: jeff Branches: FC-6 F-7 devel InitialCC: cvs done. Packages built... Package Change Request ====================== Package Name: perl-CGI-FastTemplate New Branches: el6 Owners: ktdreyer InitialCC: perl-sig Emailed Jeff via personal email last week. I'll be maintaining the EL6 branch to support ikiwiki in EPEL. Git done (by process-git-requests). Package Change Request ====================== Package Name: perl-CGI-FormBuilder New Branches: epel7 Owners: ktdreyer InitialCC: perl-sig Sigh, bad copy & paste... Package Change Request ====================== Package Name: perl-CGI-FastTemplate New Branches: epel7 Owners: ktdreyer InitialCC: perl-sig Git done (by process-git-requests). |