Bug 2442626

Summary:	Review Request: postgresql16-pg_tle - Framework for building and installing trusted language PostgreSQL extensions.
Product:	[Fedora] Fedora	Reporter:	Nikola Davidova <ndavidov>
Component:	Package Review	Assignee:	Petr Khartskhaev <pkhartsk>
Status:	RELEASE_PENDING ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, pkhartsk
Target Milestone:	---	Flags:	pkhartsk: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nikola Davidova 2026-02-25 14:05:52 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/ndavidov/pg_tle/fedora-rawhide-x86_64/10190041-postgresql16-pg_tle/postgresql16-pg_tle.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ndavidov/pg_tle/srpm-builds/10190041/postgresql16-pg_tle-1.5.2-1.fc45.src.rpm
Description: Trusted Language Extensions (pg_tle) is an open-source development kit for
building and deploying PostgreSQL extensions without requiring access to
the underlying file system.
Fedora Account System Username: ndavidov

Comment 1 Nikola Davidova 2026-03-04 11:35:44 UTC

The package looks good and build in Mock.

Reviewer Notes:
- undefined-non-weak-symbol is expected as this extension relies on the main PostgreSQL server binary,
- unversioned.so file is expected behavior and is installed to the private %{_libdir}/pgsql directory.
- missing %check section: justified in the spec file, testing is handled downstream
- conflicts are justified as this is a standard mechanism uto prevent multiple extension versions.

Below is the completed review template:
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "PostgreSQL License", "*No copyright*
     PostgreSQL License". 28 files have unknown license. Detailed output of
     licensecheck in
     /home/ndavidov/work/fedora/pg_cron/FedoraReview/2442963-postgresql16-pg_cron/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 21362 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[-]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: postgresql16-pg_cron-1.6.7-1.fc45.x86_64.rpm
          postgresql16-pg_cron-1.6.7-1.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6mplrq9_')]
checks: 32, packages: 2

postgresql16-pg_cron.spec:47: W: unversioned-explicit-provides %{extension}-any
postgresql16-pg_cron.spec: W: no-%check-section
 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 0.2 s 




Rpmlint (debuginfo)
-------------------
Checking: postgresql16-pg_cron-debuginfo-1.6.7-1.fc45.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp2m2p8pp3')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CurrentExtensionObject	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SPI_processed	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so PostPortNumber	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CurrentMemoryContext	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so tag_hash	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so IsBinaryUpgrade	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so max_worker_processes	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so MyLatch	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so debug_query_string	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so MyProc	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so check_timezone	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so TopMemoryContext	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so max_files_per_process	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so nextval_oid	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so StatementTimeout	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so creating_extension	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so process_shared_preload_libraries_in_progress	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so die	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SPI_tuptable	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so MaxConnections	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so InterruptPending	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CurrentResourceOwner	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so MyProcPid	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so GetUserNameFromId	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so superuser	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_toc_allocate	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so systable_endscan	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so palloc0	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so resetStringInfo	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so BeginCommand	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so get_rel_name	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so StartTransactionCommand	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so dsm_detach	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so hash_seq_search	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_toc_estimate	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SetConfigOption	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so analyze_requires_snapshot	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_mq_attach	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so GetUserId	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so set_ps_display_with_len	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CommitTransactionCommand	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so DefineCustomEnumVariable	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so hash_create	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so makeRangeVarFromNameList	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_mq_create	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so enlargeStringInfo	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so nocachegetattr	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so ScanKeyInit	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so get_fn_expr_argtype	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so table_open	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_class_aclcheck	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so GetCommandTagName	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so get_relname_relid	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_plan_queries	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so quote_qualified_identifier	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so EndCommand	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CacheInvalidateRelcacheByTuple	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so errmsg_internal	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_tzset	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so textToQualifiedNameList	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so ProcessConfigFile	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so get_extension_oid	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so PortalSetResultFormat	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_toc_insert	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so lappend	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SPI_execute_with_args	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so ReleaseSysCache	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CreatePortal	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so DefineCustomIntVariable	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so initStringInfo	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so text_to_cstring	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so RecoveryInProgress	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so errstart	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_localtime	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so systable_beginscan	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so WaitLatch	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so PortalRun	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so disable_timeout	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so cstring_to_text	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so simple_heap_delete	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so GetUserIdAndSecContext	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so PortalDrop	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_toc_create	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so RangeVarGetRelidExtended	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SetUserIdAndSecContext	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SetCurrentStatementStartTimestamp	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so PortalStart	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SPI_connect	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SPI_getbinval	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so ResetLatch	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so AcceptInvalidationMessages	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so appendStringInfo	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SPI_exec	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so hash_search	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so dsm_create	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CreateCommandTag	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so TerminateBackgroundWorker	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pq_redirect_to_shm_mq	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_detoast_datum	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so dsm_segment_address	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_snprintf	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so getmissingattr	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so GetBackgroundWorkerPid	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SearchSysCache1	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_lltoa	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pgstat_report_activity	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pstrdup	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so AllocSetContextCreateInternal	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so get_database_oid	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pgstat_report_stat	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so GetCurrentTimestamp	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so WaitForBackgroundWorkerShutdown	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so PortalDefineQuery	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so PopActiveSnapshot	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so systable_getnext	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_parse_query	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_toc_attach	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so BackgroundWorkerUnblockSignals	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so enable_timeout_after	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so ProcessInterrupts	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so dsm_segment_handle	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so errmsg	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so proc_exit	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so WaitForBackgroundWorkerStartup	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so add_size	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_strcasecmp	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so superuser_arg	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so GetTransactionSnapshot	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so RegisterDynamicBackgroundWorker	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so RegisterBackgroundWorker	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so PushActiveSnapshot	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CommandCounterIncrement	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so get_role_oid	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_mq_receive	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_toc_lookup	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_mq_set_sender	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pq_getmsgbyte	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so errdetail	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so ResourceOwnerCreate	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so shm_mq_set_receiver	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pq_getmsgstring	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so errfinish	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so GetDatabaseEncodingName	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so TimestampDifference	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CreateDestReceiver	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so hash_seq_init	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so DirectFunctionCall1Coll	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so timestamptz_to_time_t	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so DefineCustomStringVariable	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so errhint	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so BackgroundWorkerInitializeConnection	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pgstat_report_appname	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so dsm_attach	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pq_parse_errornotice	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so get_namespace_oid	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SPI_finish	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so TimestampDifferenceExceeds	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so CacheRegisterRelcacheCallback	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_analyze_and_rewrite_fixedparams	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so object_aclcheck	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so MemoryContextReset	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pfree	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so table_close	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so ReadyForQuery	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so DefineCustomBoolVariable	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so asc_tolower	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so SetLatch	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so errcode	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so pg_sprintf	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so aclcheck_error	(/usr/lib64/pgsql/pg_cron.so)
postgresql16-pg_cron.x86_64: W: undefined-non-weak-symbol /usr/lib64/pgsql/pg_cron.so errstart_cold	(/usr/lib64/pgsql/pg_cron.so)
 2 packages and 0 specfiles checked; 0 errors, 171 warnings, 9 filtered, 0 badness; has taken 0.5 s 



Unversioned so-files
--------------------
postgresql16-pg_cron: /usr/lib64/pgsql/pg_cron.so

Source checksums
----------------
https://github.com/citusdata/pg_cron/archive/refs/tags/v1.6.7.tar.gz :
  CHECKSUM(SHA256) this package     : d950bc29155f31017567e23a31d268ff672e98276c0e9d062512fb7870351f03
  CHECKSUM(SHA256) upstream package : d950bc29155f31017567e23a31d268ff672e98276c0e9d062512fb7870351f03


Requires
--------
postgresql16-pg_cron (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libpq.so.private16-5()(64bit)
    postgresql16-server
    rtld(GNU_HASH)



Provides
--------
postgresql16-pg_cron:
    pg_cron-any
    postgresql16-pg_cron
    postgresql16-pg_cron(x86-64)



Generated by fedora-review 0.11.0 (a1aac9a) last change: 2025-12-06
Command line :try-fedora-review -b 2442963 -o --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --isolation=simple
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Java, PHP, Perl, R, Haskell, Ocaml, Python, SugarActivity, fonts, Ruby
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 2 Nikola Davidova 2026-03-04 11:46:51 UTC

Apologies, Comment #1 was intended for a different ticket and does not apply to this issue. Please disregard

Comment 3 Petr Khartskhaev 2026-03-04 13:38:50 UTC

The package looks good and builds in Mock.

Reviewer Notes:
- unversioned.so file is expected behavior and is installed to the private %{_libdir}/pgsql directory.
- missing %check section: justified in the spec file, testing is handled downstream
- conflicts are justified as this is a standard mechanism to prevent multiple extension versions.

Below is the completed review template:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "Apache License 2.0". 48 files have unknown license. Detailed output
     of licensecheck in /var/lib/copr-
     rpmbuild/results/postgresql16-pg_tle/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 4100 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: postgresql16-pg_tle-1.5.2-1.fc45.x86_64.rpm
          postgresql16-pg_tle-1.5.2-1.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpvhk09m0i')]
checks: 32, packages: 2

postgresql16-pg_tle.spec:38: W: unversioned-explicit-provides %{sname}-any
postgresql16-pg_tle.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
postgresql16-pg_tle.spec: W: no-%check-section
 2 packages and 0 specfiles checked; 0 errors, 3 warnings, 7 filtered, 0 badness; has taken 0.1 s 




Rpmlint (debuginfo)
-------------------
Checking: postgresql16-pg_tle-debuginfo-1.5.2-1.fc45.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpkdfl1svg')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s 





Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "postgresql16-pg_tle-debuginfo".
(none): E: there is no installed rpm "postgresql16-pg_tle".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 



Unversioned so-files
--------------------
postgresql16-pg_tle: /usr/lib64/pgsql/pg_tle.so

Source checksums
----------------
https://github.com/aws/pg_tle/archive/refs/tags/v1.5.2.tar.gz :
  CHECKSUM(SHA256) this package     : 6fe53496541a4cc763f18614d5ea91c57f64ac6b292f54f7346197961ab47341
  CHECKSUM(SHA256) upstream package : 6fe53496541a4cc763f18614d5ea91c57f64ac6b292f54f7346197961ab47341


Requires
--------
postgresql16-pg_tle (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    postgresql16-server
    rtld(GNU_HASH)



Provides
--------
postgresql16-pg_tle:
    pg_tle-any
    postgresql16-pg_tle
    postgresql16-pg_tle(x86-64)



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name postgresql16-pg_tle --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: Haskell, Java, SugarActivity, PHP, R, Ocaml, Python, fonts, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 4 Fedora Admin user for bugzilla script actions 2026-03-04 17:21:09 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/postgresql16-pg_tle