Bug 244373
| Summary: | Review Request: sugar-presence-service - Sugar presence service | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marco Pesenti Gritti <mpg> | ||||
| Component: | Package Review | Assignee: | Ignacio Vazquez-Abrams <ivazquez> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | dcbw, mail, pbrobinson, tomeu | ||||
| Target Milestone: | --- | Flags: | ivazqueznet:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-06-19 20:36:57 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 244371, 462625 | ||||||
| Attachments: |
|
||||||
|
Description
Marco Pesenti Gritti
2007-06-15 10:04:47 UTC
The plan is to add this package to the olpc-2 branch. Created attachment 157206 [details]
Patch for spec file
rpmlint output:
sugar-presence-service-0.65-1.git52b8a7428a.1.i386.rpm:
W: sugar-presence-service no-documentation
E: sugar-presence-service no-binary
sugar-presence-service-0.65-1.git52b8a7428a.1.src.rpm:
W: sugar-presence-service mixed-use-of-spaces-and-tabs (spaces: line 3, tab:
line 14)
sugar-presence-service-debuginfo-0.65-1.git52b8a7428a.1.i386.rpm:
E: sugar-presence-service-debuginfo empty-debuginfo-package
NOTE: I received a weird message during git-checkout. I don't know enough about
git to tell what the issue is:
$ git-checkout 52b8a7428a
Note: moving to "52b8a7428a" which isn't a local branch
If you want to create a new branch from this checkout, you may do so
(now or later) by using -b with the checkout command again. Example:
git checkout -b <new_branch_name>
Patch included.
Applied the patch, thanks! I also updated the snapshot. I think the old one had incorrect git commit id, hence the git-checkout error. http://dev.laptop.org/~marco/sugar-presence-service-0.65-1.git8f3a97dbda.1.src.rpm http://dev.laptop.org/~marco/sugar-presence-service.spec I see that sugar owns %{_datadir}/sugar/, but I didn't verify that it owns
%{_datadir}/sugar/services/. If it doesn't then you'll need to make this package
own it. If it does then you'll need to make this package Require sugar.
This package should also require dbus for %{_datadir}/dbus-1/services/.
>I see that sugar owns %{_datadir}/sugar/, but I didn't verify that it owns
>%{_datadir}/sugar/services/. If it doesn't then you'll need to make this package
>own it. If it does then you'll need to make this package Require sugar.
I'm not really sure what to do here. Sugar install other services in
%{_datadir}/sugar/services/ so I guess it should own the dir. Though the
presence service should not require Sugar.
Maybe the sources should be fixed to install in
%{_datadir}/sugar-presence-service. CCing Dan about it.
Yeah, installing it outside %{_datadir}/sugar sounds like the right thing to do
since it doesn't depend on sugar. %{_datadir}/sugar-presence-service sounds
good for now.
Fixed. http://dev.laptop.org/~marco/sugar-presence-service-0.65-1.gite335c3678f.1.src.rpm http://dev.laptop.org/~marco/sugar.spec I'll approve it, but you might want to fix up the release. Thanks, I'll fix the release before importing. New Package CVS Request ======================= Package Name: sugar-presence-service Short Description: The Sugar presence service Owners: mpg Branches: OLPC-2 InitialCC: mpg CVS done. Package Change Request ====================== Package Name: sugar-presence-service New Branches: F-11 Package Change Request ====================== Package Name: sugar-presence-service New Branches: F-10 CVS Done Package Change Request ====================== Package Name: sugar-presence-service New Branches: OLPC-4 Owners: mpg erikos tomeu cvs done. Package Change Request ====================== Package Name: sugar-presence-service New Branches: EL-6 Owners: pbrobinson sdz cvs done. |