Bug 244377
| Summary: | Review Request: sugar-artwork - Artwork for Sugar look-and-feel | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marco Pesenti Gritti <mpg> | ||||
| Component: | Package Review | Assignee: | Ignacio Vazquez-Abrams <ivazqueznet> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | mail, pbrobinson, tomeu | ||||
| Target Milestone: | --- | Flags: | ivazqueznet:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-06-18 20:37:38 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 462625 | ||||||
| Attachments: |
|
||||||
|
Description
Marco Pesenti Gritti
2007-06-15 10:34:36 UTC
Builds fine in mock on F7/i386. rpmlint output: sugar-artwork-0.33-3.git265782537a.i386.rpm: E: sugar-artwork zero-length /usr/share/doc/sugar-artwork-0.33/NEWS E: sugar-artwork script-without-shebang /usr/share/themes/sugar-xo/gtk-2.0/gtkrc E: sugar-artwork zero-length /usr/share/doc/sugar-artwork-0.33/ChangeLog E: sugar-artwork script-without-shebang /usr/share/themes/sugar/gtk-2.0/gtkrc E: sugar-artwork standard-dir-owned-by-package /usr/share/icons W: sugar-artwork incoherent-version-in-changelog 0.33-3.git5640efb030 0.33-3.git265782537a W: sugar-artwork empty-%post sugar-artwork-0.33-3.git265782537a.src.rpm: W: sugar-artwork prereq-use gtk2 >= 2.9.0 sugar-artwork-debuginfo-0.33-3.git265782537a.i386.rpm: (empty) The included patch along with http://dev.laptop.org/ticket/1736 should clear the package. Created attachment 157194 [details]
Patch for spec file
Thanks for the patches! http://dev.laptop.org/~marco/sugar-artwork-0.33-3.git5aef11739b.src.rpm http://dev.laptop.org/~marco/sugar-artwork.spec Approved. New Package CVS Request ======================= Package Name: sugar-artwork Short Description: Artwork for Sugar look-and-feel Owners: mpg Branches: olpc-2 InitialCC: mpg CVS done. Damn, I should have noticed before branching this package, but it violates the naming guidelines and now that it's in, fixing it isn't going to be possible. According to the naming guidelines, the name should be: sugar-artwork-0.33-0.3.(date)git5aef11739b Can you point me to the naming guidelines please? So that I get the other packages right at least... Isn't fixing it just matter of changing the release number? The naming guidelines are at http://fedoraproject.org/wiki/Packaging/NamingGuidelines Note that there's a pending draft to allow the commit ID after the "git" bit. The fix is just a change of the release number, but the proper release number is less than the one in use. You could always just remove the first "0." from the one from the guidelines and add it in the next time upstream increments the version. OK, I'll do that then. Package Change Request ====================== Package Name: sugar-artwork New Branches: F-11 Package Change Request ====================== Package Name: sugar-artwork New Branches: F-10 CVS Done Package Change Request ====================== Package Name: sugar-artwork New Branches: OLPC-4 Owners: mpg erikos tomeu cvs done. Package Change Request ====================== Package Name: sugar-artwork New Branches: EL-6 Owners: pbrobinson sdz cvs done. |