Bug 2444022

Created attachment 2131771 [details]
rust2rpm.toml

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10185513
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2444022-rust-tonic-prost/fedora-rawhide-x86_64/10185513-rust-tonic-prost/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

No issues found; the package is APPROVED.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

The spec file is exactly as generated by rust2rpm with the provided
rust2rpm.toml, greatly simplifying the review. (Any differences are due to
rpmautospec macro expansion.)


Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/cargo/registry/tonic-
  prost-0.14.5/LICENSE
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files

  OK: not a serious problem; due to reasonable rust2rpm design choices


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License". 7 files have unknown
     license. Detailed output of licensecheck in
     /home/ben/fedora/review/2444022-rust-tonic-prost/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.

     The license file is missing from the released crate; it is correctly and
     necessarily patched in from upstream, upstream was notified, and an
     upstream link is present in the submission.

[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     tonic-prost-devel , rust-tonic-prost+default-devel
[x]: Package functions as described.

     (tests pass)

[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.

     The license file is missing from the released crate; it is correctly and
     necessarily patched in from upstream, upstream was notified, and an
     upstream link is present in the submission.

[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: rust-tonic-prost-devel-0.14.5-1.fc45.noarch.rpm
          rust-tonic-prost+default-devel-0.14.5-1.fc45.noarch.rpm
          rust-tonic-prost-0.14.5-1.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpu_d73m3a')]
checks: 32, packages: 3

 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 19 filtered, 0 badness; has taken 0.3 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 13 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://crates.io/api/v1/crates/tonic-prost/0.14.5/download#/tonic-prost-0.14.5.crate :
  CHECKSUM(SHA256) this package     : a55376a0bbaa4975a3f10d009ad763d8f4108f067c7c2e74f3001fb49778d309
  CHECKSUM(SHA256) upstream package : a55376a0bbaa4975a3f10d009ad763d8f4108f067c7c2e74f3001fb49778d309
https://github.com/hyperium/tonic/raw/refs/tags/v0.14.5/LICENSE :
  CHECKSUM(SHA256) this package     : e24a56698aa6feaf3a02272b3624f9dc255d982970c5ed97ac4525a95056a5b3
  CHECKSUM(SHA256) upstream package : e24a56698aa6feaf3a02272b3624f9dc255d982970c5ed97ac4525a95056a5b3


Requires
--------
rust-tonic-prost-devel (rpmlib, GLIBC filtered):
    (crate(bytes/default) >= 1.0.0 with crate(bytes/default) < 2.0.0~)
    (crate(prost/default) >= 0.14.0 with crate(prost/default) < 0.15.0~)
    (crate(tonic) >= 0.14.0 with crate(tonic) < 0.15.0~)
    cargo

rust-tonic-prost+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(tonic-prost)



Provides
--------
rust-tonic-prost-devel:
    crate(tonic-prost)
    rust-tonic-prost-devel

rust-tonic-prost+default-devel:
    crate(tonic-prost/default)
    rust-tonic-prost+default-devel



Diff spec file in url and in SRPM
---------------------------------
--- /home/ben/fedora/review/2444022-rust-tonic-prost/srpm/rust-tonic-prost.spec	2026-04-15 13:30:39.246440275 +0100
+++ /home/ben/fedora/review/2444022-rust-tonic-prost/srpm-unpacked/rust-tonic-prost.spec	2026-03-02 00:00:00.000000000 +0000
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.3)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 # Generated by rust2rpm 28
 %bcond check 1
@@ -70,3 +80,6 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Mon Mar 02 2026 John Doe <packager> - 0.14.5-1
+- Uncommitted changes
+## END: Generated by rpmautospec


Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -L tonic-prost-deps/ -b 2444022
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: PHP, Ocaml, C/C++, Haskell, R, SugarActivity, Java, Perl, Python, fonts
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Built with local dependencies:
    /home/ben/fedora/review/tonic-prost-deps/rust-prost-devel-0.14.3-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-prost+default-devel-0.14.3-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-prost+derive-devel-0.14.3-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-prost+no-recursion-limit-devel-0.14.3-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-prost+std-devel-0.14.3-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+_tls-any-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+channel-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+codegen-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+default-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+deflate-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+gzip-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+router-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+server-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+tls-connect-info-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+tls-native-roots-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+tls-ring-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+tls-webpki-roots-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+transport-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-tonic+zstd-devel-0.14.5-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-prost-derive-devel-0.14.3-1.fc45.noarch.rpm
    /home/ben/fedora/review/tonic-prost-deps/rust-prost-derive+default-devel-0.14.3-1.fc45.noarch.rpm

Thank you for the review, Ben

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tonic-prost