Bug 244411

Does this do anything that "package-cleanup --leaves" doesn't do?

(package-cleanup is in the yum-utils package)

I think that is good to have a tool that doesn't depend on yum, eg: people 
using apt or smart would appreciate it (imho) :-)

I am not able to get to either the SRPM or the SPEC??

You should be able to get it now. The SPEC and the SRPM are hosted on my 
CentOS 5 server which is sometimes under maintenance (yesterday i was working 
on reducing fan noise) :-) 

This is not an official review as I am not sponsored yet.  But I hope it will help.

FIX - rpmlint not quiet
        Source RPM
        W: rpmorphan summary-not-capitalized rpmorphan list the orphaned rpm
packages.
        W: rpmorphan summary-ended-with-dot rpmorphan list the orphaned rpm
packages.

        Binary RPM
        rpmlint rpmorphan-1.0-1.fc7.noarch.rpm 
        W: rpmorphan spurious-executable-perm
/usr/share/doc/rpmorphan-1.0/test_rpmorphan.pl
        E: rpmorphan standard-dir-owned-by-package /usr/bin
        E: rpmorphan zero-length /var/lib/rpmorphan/keep
        E: rpmorphan standard-dir-owned-by-package /usr/share/man/man1
        W: rpmorphan summary-not-capitalized rpmorphan list the orphaned rpm
packages.
        W: rpmorphan summary-ended-with-dot rpmorphan list the orphaned rpm
packages.
        W: rpmorphan doc-file-dependency
/usr/share/doc/rpmorphan-1.0/test_rpmorphan.pl perl(Test::More)

FIX - Source0 should be a URL to the upstream source
       
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2


OK - Mock : Built on F7 (x86)
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
FIX - Spec has consistant macro usage.
        File section has a mix of macros and no macros.  See
http://fedoraproject.org/wiki/Packaging/RPMMacros for a listing of
        macros
OK - License field in spec matches
OK - License is GPL
OK - License file is included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources SHOULD match upstream md5sum:
560f78f6efe95a864072de6829bb8e00  rpmorphan-1.0.tar.gz
OK - Package has correct buildroot.
OK - extras BuildRequires are not redundant.
OK - %build and %install stages are correct and work.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has no duplicate files in %files.
FIX - Package doesn't own any directories that other packages own.
        RPM tries to own /usr/bin (%dir %{_bindir})
        RPM tries to own /usr/share/man/man1 (dir %{_mandir}/man1)
? - Changelog section is correct. 
        I am not sure what the rule actually is, but all the examples and other
SPECs I have looked at didn't have the .fc7  as part of the changlog entry
        Also might consider putting in something other than just 1.0 such as
Initial RPM Release, here again I am not sure what the rule is, but everyone seems
        to use that.
OK - Should function as described.
OK - Should package latest version

Package builds, installs and runs OK in F7 x86

Fixed SPEC and SRPM at usual location:

rpmlint:
W: rpmorphan summary-not-capitalized rpmorphan list the orphaned rpm
packages. << should be fixed now
W: rpmorphan summary-ended-with-dot rpmorphan list the orphaned rpm
packages. << should be fixed now

rpmlint with binary rpm:
Other should be fixed now but:
E: rpmorphan zero-length /var/lib/rpmorphan/keep
Can't be fixed. It seems to be a needed directory. I'll investigate.

These should be fixed now:
FIX [FIXED] - Source0 should be a URL to the upstream source
FIX [FIXED] - Spec has consistant macro usage. File section has a mix of 
macros and no macros.
FIX [FIXED] - Package doesn't own any directories that other packages own.
? [FIXED] - Changelog section << added - Initial RPM Release for completeness

Lorenzo, are you still interested in submitting this package? The URLs you give
for the spec and srpm files give 404 - not found.

(In reply to comment #7)
> [cut]
I'm closing this bug report for now since I don't have much time to work on 
this package :(
I'll probably reopen this bug in the future when i will have enought time to 
work on it.

I've opened a new package review without realising
this one existed already.

*** This bug has been marked as a duplicate of bug 490462 ***