Bug 244523
Summary: | Review Request: ddrescue - Data recovery tool | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Damien Durand <splinux25> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | bjohnson, opensource |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | ddrescue-1.18.1-1.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-07-05 09:19:13 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Damien Durand
2007-06-16 17:29:23 UTC
rpm's CXX flags: + CXXFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables' are reset and not used in the build (from build.log): CC = gcc CXX = g++ CPPFLAGS = CFLAGS = -Wall -W -O2 CXXFLAGS = -Wall -W -O2 LDFLAGS = OK. Now you can run make. + make g++ -Wall -W -O2 -c -o arg_parser.o arg_parser.cc g++ -Wall -W -O2 -c -o block.o block.cc g++ -Wall -W -O2 -c -o ddrescue.o ddrescue.cc g++ -Wall -W -O2 -c -o logbook.o logbook.cc g++ -Wall -W -O2 -DPROGVERSION=\"1.3\" -c -o main.o main.cc g++ -o ddrescue arg_parser.o block.o ddrescue.o logbook.o main.o * Sat Jun 23 2007 Damien Durand <splinux> - 1.4-1 - Upgrade to 1.4 - Fix flags Spec URL: http://glive.tuxfamily.org/fedora/ddrescue/ddrescue.spec SRPM URL: http://glive.tuxfamily.org/fedora/ddrescue/ddrescue-1.4-1.fc8.src.rpm (In reply to comment #2) > - Fix flags You can't do it that way because you just broke every arch other than x86. You can either a) fix configure to realize that CXXFLAGS and friends are already set in the environment, or b) pass CXXFLAGS on the configure command line ie. (%configure CXXFLAGS="$(CXXFLAGS)") Blocker: Fedora contains "ddrescue" and "dd_rescue". There are several versions of the tool. The current Fedora package "Obsoletes: ddrescue"! (In reply to comment #4) > Blocker: Fedora contains "ddrescue" and "dd_rescue". There are several > versions of the tool. The current Fedora package "Obsoletes: ddrescue"! Hmm. I didn't even notice that since it was named differently. Damien, you probably want to close this as NOTABUG. (In reply to comment #4) > Blocker: Fedora contains "ddrescue" and "dd_rescue". There are several > versions of the tool. The current Fedora package "Obsoletes: ddrescue"! > Afaik, Fedora only contains dd_rescue which was packaged with the wrong name ddrescue. At least the changelog in rpms/ddrescue imply this. dd_rescue in Fedora is from http://www.garloff.de/kurt/linux/ddrescue/ and the version in this review was from gnu. So if someone still wants to package ddrescue, please reopen the bug and a bug against dd_rescue, not to obsolete ddrescue. Maybe an versioned Obsoletes works here, because dd_rescue has a lower version that ddrescue. Also before you can import ddrescue after an successfull review, some cvs master has to clean up cvs first I guess. ddrescue-1.18.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ddrescue-1.18.1-1.el7 ddrescue-1.18.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |