Bug 2446919
| Summary: | Review Request: mcp-dap-server - MCP server to communicate with DAP servers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alejandro Sáez Morollón <asm> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-03-12 11:55:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alejandro Sáez Morollón
2026-03-12 09:33:18 UTC
Not sure if it will be used at all, but goreleaser is setting main.version=%{version}, so you may want to add the following before importing, after the "%global gomodulesmode GO111MODULE=on" line:
export GO_LDFLAGS="-X main.version=%{version}"
Golang Package Review
==============
This package was generated using go2rpm and Go Vendor Tools, which simplifies
the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution.
- [x] There are no `%{_bindir}/*` wildcards in %files.
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.
- [x] GO_LDFLAGS are set correctly. <-- check my comment
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance
Thanks! I added the line. The Pagure repository was created at https://src.fedoraproject.org/rpms/mcp-dap-server FEDORA-2026-2a8dfc3519 (mcp-dap-server-0-0.1.20260312gitfd732ee.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-2a8dfc3519 FEDORA-2026-2a8dfc3519 (mcp-dap-server-0-0.1.20260312gitfd732ee.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report. |