Bug 244752
Summary: | Review Request: mod_dnssd - An Apache HTTPD module which adds Zeroconf support | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ignacio Vazquez-Abrams <ivazqueznet> |
Component: | Package Review | Assignee: | Ruben Kerkhof <ruben> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | lpoetter |
Target Milestone: | --- | Flags: | ruben:
fedora-review+
wtogami: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-06-30 17:19:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ignacio Vazquez-Abrams
2007-06-18 22:04:56 UTC
Hi Ignacio, Review for release 1: * RPM name is OK * Source mod_dnssd-0.5.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint looks OK * File list looks OK * Config files of mod_dnssd looks OK * I have been able to publish some virtual hosts, guided by the included README file. They showed up nicely in Safari on my Mac Notes: - Can you add LoadModule dnssd_module modules/mod_dnssd.so to mod_dnssd.conf? - Publishing ~/user dirs didn't show up (public_html in my homedir) Updated. http://www.hotlinkfiles.com/files/93587_vi1nn/mod_dnssd.spec http://www.hotlinkfiles.com/files/93588_78oll/mod_dnssd-0.5-2.fc7.src.rpm (In reply to comment #1) > Notes: > - Can you add LoadModule dnssd_module modules/mod_dnssd.so to mod_dnssd.conf? Fixed. > - Publishing ~/user dirs didn't show up (public_html in my homedir) Even when uncommenting DNSSDAutoRegisterUserDir? Hrm. CCing upstream. > Even when uncommenting DNSSDAutoRegisterUserDir? Hrm. CCing upstream
Yes, I tried to walk through the module with gdb, but it forks a child process early during httpd startup,
and I couldn't step through it.
But anyway, the package itself looks good, and most of the functionality works, so it's approved.
New Package CVS Request ======================= Package Name: mod_dnssd Short Description: An Apache HTTPD module which adds Zeroconf support Owners: ivazqueznet Branches: F-6, F-7 InitialCC: cvs done. Ignacio: thanks for packaging this. I'd love to be added as a CC for bugs. Hmm, DNSSDAutoRegisterUserDir might not have worked on your machine due to a couple of reasons: 1. You hit the trivial bug i fixed in upstream r63. (Ignacio, you probably want to add this patch to your package!) 2. Your userdir is a symlink? 3. Your userdir is not accessible for the user apache uses? Most likely is reason #1. Package Change Request ====================== Package Name: mod_dnssd Updated Fedora CC: lpoetter |