Bug 2447802

Summary: Review Request: rust-ogg - Ogg container decoder and encoder written in pure Rust
Product: [Fedora] Fedora Reporter: Jonathan Steffan <jonathansteffan>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jonathan Steffan 2026-03-15 22:09:26 UTC
Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-ogg.spec
SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-ogg-0.9.2-1.fc45.src.rpm
Description: Ogg container decoder and encoder written in pure Rust.
Fedora Account System Username: jsteffan

Comment 1 Fabio Valentini 2026-08-19 14:40:50 UTC
There's some files in this crate that don't match the crate's license text and metadata.

It looks like the crate was relicensed from "MIT OR Apache-2.0" to "BSD-3-Clause" at some point, but some things were not updated: the examples/*.rs and tests/*.rs files all have a copyright header that says:

// Licensed under MIT license, or Apache 2 license,
// at your option. Please see the LICENSE file
// attached to this source distribution for details.

But the LICENSE file contains a BSD-3-Clause license.

Comment 2 Jonathan Steffan 2026-08-29 21:37:31 UTC
Changelog:

- Added the missing rust-ogg-rust2rpm.toml, capturing the existing license-header patch (fixing examples/*.rs headers left over from before the crate's relicense to BSD-3-Clause) so rust2rpm regeneration reproduces the spec exactly
- Verified the single tests/*.rs file already carries the corrected header; only examples/*.rs needed the patch
- Renumbered the patch tag to Patch2, reserving slots 0-1 for a future Cargo.toml metadata patch

Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-ogg.spec
SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-ogg-0.9.2-1.fc44.src.rpm
rust2rpm.toml URL: https://jsteffan.fedorapeople.org/xrizer/rust-ogg-rust2rpm.toml