Bug 2447805
| Summary: | Review Request: rust-quad-alsa-sys - Fork of original alsa-sys, but with pkg-config replaced with -lasound | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Steffan <jonathansteffan> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jonathan Steffan
2026-03-15 22:10:21 UTC
Changelog: - Add rust2rpm toml, incorporate any feedback Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys.spec SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys-0.3.2-1.fc43.src.rpm rust2rpm.toml URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys-rust2rpm.toml There seems to be some problem with the following file. SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys-0.3.2-1.fc43.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Changelog: - Add rust2rpm toml, incorporate any feedback Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys.spec SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys-0.3.2-1.fc45.src.rpm rust2rpm.toml URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys-rust2rpm.toml A few issues: - Built packages don't install (dependency on bindgen too old). - Drop "regenerate_bindings" executable. This is only used for upstream development (to regenerate the pre-generated bindings). - Make the "use-bindings" feature a noop and unconditionally regenerate bindings with bindgen at build-time (this will require patches for Cargo.toml and build.rs). If it is possible to do so, pregenerated code should be dropped and regenerated during the build. - Drop "regenerate_bindings.sh" script, it causes a dependency on "sh" to be generated for the package. Changelog: - Fixed built packages failing to install: bindgen was an optional 0.56-pinned build-dependency, unsatisfiable since Fedora only ships bindgen 0.72; made it mandatory, pinned to 0.72 - Dropped the "regenerate_bindings" dev-only helper binary and regenerate_bindings.sh (never actually buildable, and its #!/bin/sh shebang pulled an unwanted /usr/bin/sh dependency onto -devel) - Bindings are now unconditionally regenerated from live ALSA headers at build time instead of shipping a stale pregenerated src/generated.rs; fixed the ALSA header include path and updated to the bindgen 0.72 API - Reworked the Cargo.toml fix to use rust2rpm's own metadata-patch mechanism and added pkgconfig(alsa) Requires/BuildRequires, so rust2rpm regeneration now reproduces the spec exactly Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys.spec SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys-0.3.2-1.fc44.src.rpm rust2rpm.toml URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-alsa-sys-rust2rpm.toml |