Bug 244848

Description of problem:
When serving files from an NFS export with quotas enabled, the "quota full"
error is not propagated to windows clients at a moment when they are willing to
let the user know. The result is that users will have their files truncated
without notice.


Version-Release number of selected component (if applicable):
3.0.10-1.4E.12.2


How reproducible:
On a samba share based on any quota-limited NFS exported file system (reproduced
both with Solaris NFS server and Linux NFS server)


Steps to Reproduce:
1. From a Windows 2000 client, fill up the share with a total file size that
exceeds quota
2.
3.
  
Actual results:
Files are left in the share, truncated with size 0, user doesn't receive an
error message.

Expected results:
Files shouldn't be left truncated on the share, user should receive an error
message.

Additional info:
Jeremy Allison <jra> acknowledged the problem and produced the patch
I'm attaching. The patch makes samba check the errors that might be returned by
the fsync call. It applies to 3.0.25c

By activating the "strict sync" and "sync always" smb.conf directives, Samba
syncs the file while it's being written, thus being able to report the quota
error at that moment. This is a good moment for Windows to acknowledge the
error. (on close(), it's too late)