Bug 2448654
| Summary: | Review Request: i2p - Anonymous network for privacy-preserving communication | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | admin | ||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 43 | CC: | admin, fabio.porcedda, package-review | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://i2p.net/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | --- | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
admin
2026-03-18 16:39:21 UTC
Notes for reviewer: - rpmlint 3 errors are intentional 750 permissions on /var/lib/i2p and /var/log/i2p (security: only i2p service user should access router state). Justified in rpmlintrc (included in SOURCES/). - no-%check-section: I2P upstream has no test suite suitable for RPM builds. - Bundled JARs in source tarball (izpack, launch4j, gradle-wrapper, Jetty, Tomcat) are build tooling only — not shipped in final RPM. Everything is rebuilt from source via `ant preppkg-linux-only`. - class-path-in-manifest warnings are upstream convention (JAR manifests). - Duplicate flag PNGs between eepsite help and docs are upstream layout. Copr build: https://copr.fedorainfracloud.org/coprs/build/10238038 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2448654-i2p/fedora-rawhide-x86_64/10238038-i2p/fedora-review/review.txt Found issues: - No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - No javadoc subpackage present Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Jar files in source (see attachment) Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_pre_built_dependencies Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated package to -3 [fedora-review-service-build] Created attachment 2134048 [details]
The .spec file difference from Copr build 10238038 to 10238110
Copr build: https://copr.fedorainfracloud.org/coprs/build/10238110 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2448654-i2p/fedora-rawhide-x86_64/10238110-i2p/fedora-review/review.txt Found issues: - No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - No javadoc subpackage present Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Jar files in source (see attachment) Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_pre_built_dependencies Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hi, (In reply to admin from comment #0) > spec: > https://raw.githubusercontent.com/i2p/i2p-jpackage-rpm/refs/heads/main/SPEC/ > i2p.spec This spec file is not the same as the one inside the src.rpm file, please sync them. > srpm: https://files.i2p.net/fedora/i2p-2.11.0-3.fc41.src.rpm Updated spec and srpm due to new version SRPM: https://files.i2p.net/fedora/i2p-2.12.0-1.fc41.src.rpm Spec: https://files.i2p.net/fedora/i2p.spec Hi, please address the following issues in order to make a full review: (In reply to admin from comment #7) > Updated spec and srpm due to new version > > SRPM: https://files.i2p.net/fedora/i2p-2.12.0-1.fc41.src.rpm > Spec: https://files.i2p.net/fedora/i2p.spec 1) Spec file still refers to the 2.11.0 version. It's not aligned with the src.rpm. Please sync them. 2) The src.rpm should be for rawhide so it should be named i2p-2.12.0-1.fc45.src.rpm 3) Spec file should be listed as the first one so they should be: Spec URL: ... SRPM URL: ... Copr build: https://copr.fedorainfracloud.org/coprs/build/10405260 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2448654-i2p/fedora-rawhide-x86_64/10405260-i2p/fedora-review/review.txt Found issues: - No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - No javadoc subpackage present Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Jar files in source (see attachment) Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_pre_built_dependencies Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://files.i2p.net/fedora/i2p.spec SRPM URL: https://files.i2p.net/fedora/i2p-2.12.0-1.fc43.src.rpm Thank you for the guidance. Created attachment 2139039 [details]
The .spec file difference from Copr build 10405260 to 10416723
Copr build: https://copr.fedorainfracloud.org/coprs/build/10416723 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2448654-i2p/fedora-rawhide-x86_64/10416723-i2p/fedora-review/review.txt Found issues: - No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - No javadoc subpackage present Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Jar files in source (see attachment) Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_pre_built_dependencies Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. (In reply to admin from comment #1) > Notes for reviewer: > > - rpmlint 3 errors are intentional 750 permissions on /var/lib/i2p and > /var/log/i2p (security: only i2p service user should access router state). > Justified in rpmlintrc (included in SOURCES/). > - no-%check-section: I2P upstream has no test suite suitable for RPM builds. > - Bundled JARs in source tarball (izpack, launch4j, gradle-wrapper, Jetty, > Tomcat) are build tooling only — not shipped in final RPM. Everything is > rebuilt from source via `ant preppkg-linux-only`. AFAIK it's not possible to use jar files even just for building. Please remove them in the %prep and use in their place BuildRequires. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_pre_built_dependencies jetty is already packaged but it's an older version the 9.4.40 version, it's good enough? |