Bug 245103

Summary:	Review Request: php-spyc - A simple php yaml class
Product:	[Fedora] Fedora	Reporter:	Michael Stahnke <mastahnke>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	j: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	0.2.5-1.fc7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-07-06 12:36:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Stahnke 2007-06-21 04:30:53 UTC

Spec URL: http://www.stahnkage.com/rpms/php-spyc.spec
SRPM URL: http://www.stahnkage.com/rpms/php-spyc-0.2.5-1.src.rpm
Description: Spyc is a YAML loader/dumper written in PHP. Given a YAML
document, Spyc will return an array which you can use however
you see fit. Given an array, Spyc will return a string which
 contains a YAML document built from your data.

Comment 1 Jason Tibbitts 2007-07-04 01:40:01 UTC

Builds OK, rpmlint is quiet and everything looks good to me.  There's really not
much at all to this package.

Terribly minor: there's a stray leading space on the last line of the %description.

Note that this is a plain PHP package, not a PEAR package.

Review:
* source files match upstream:
   8598d8dbc77b79743c633345cfe47c2e8adbb8eff0d44b2d52401150dc056a3b  
   spyc-0.2.5.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-spyc = 0.2.5-1.fc8
  =
   php
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 2 Michael Stahnke 2007-07-04 02:12:09 UTC

New Package CVS Request
=======================
Package Name: php-spyc
Short Description: A simple php yaml class
Owners: mastahnke
Branches: EL-5, F-7, FC-6
InitialCC:

Comment 3 Kevin Fenzi 2007-07-04 02:19:28 UTC

cvs done.

Comment 4 Michael Stahnke 2007-07-04 02:37:23 UTC

Sorry forgot this package works without PHP5. 

New Package CVS Request
=======================
Package Name: php-spyc
Short Description: A simple php yaml class
Owners: mastahnke
Branches: EL-4
InitialCC:

Comment 5 Kevin Fenzi 2007-07-04 03:02:04 UTC

cvs done.

Comment 6 Fedora Update System 2007-07-05 19:12:36 UTC

php-spyc-0.2.5-1.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2007-07-06 12:36:23 UTC

php-spyc-0.2.5-1.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.