Bug 2453340

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10280932
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2453340-rocm-core7.2/fedora-rawhide-x86_64/10280932-rocm-core7.2/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

No issues building and installing! Just a few things I was curious about and a couple things that may need addressing:

1. (The spec contains SUSE/openSUSE conditionals:
   (%{?suse_version}) in three places:

      Package naming:
      %if 0%{?suse_version}
      %global core_name librocm-core1%{pkg_suffix}

      ldconfig scriptlets:
      %if 0%{?suse_version}
      %post -p /sbin/ldconfig
      %postun -p /sbin/ldconfig

      License file cleanup:
      # OpenSUSE
      rm -f %{buildroot}/%{pkg_prefix}/share/doc/*/*/LICENSE.md

   Not sure if I am missing something, but per the Fedora Packaging Guidelines: "Use of macros and conditionals
   for other distributions, including Fedora derivatives, is not
   permitted in spec files of packages in the main Fedora repositories."
   I am assuming this shouldn't be here, but if I'm wrong please let me know why.

 2. No %check section is present. This isn't required, but is there any
   potential tests that can be ran? If no tests exist upstream, please confirm.


== rpmlint Warnings ==
- specfile-warning setlocale: mock environment locale issue, not a
  spec problem
- only-non-binary-in-usr-lib: expected for compat -devel subpackage
  containing cmake config files
- no-documentation on -devel: minor, not a blocker
- no-%check-section: see Issue 2

(In reply to Kurtis from comment #2)
>    Not sure if I am missing something, but per the Fedora Packaging
> Guidelines: "Use of macros and conditionals
>    for other distributions, including Fedora derivatives, is not
>    permitted in spec files of packages in the main Fedora repositories."
>    I am assuming this shouldn't be here, but if I'm wrong please let me know
> why.

Hi Kurtis, where did you read this?
I skimmed https://docs.fedoraproject.org/en-US/packaging-guidelines/ and didn't see it.

> 
>  2. No %check section is present. This isn't required, but is there any
>    potential tests that can be ran? If no tests exist upstream, please
> confirm.

After a quick check, I don't believe there's any tests that can be run. In theory Unit tests could be introduced, but I don't see any upstream:
https://github.com/ROCm/rocm-systems/tree/develop/projects/rocm-core

(In reply to Jeremy Newton from comment #3)
> (In reply to Kurtis from comment #2)
> >    Not sure if I am missing something, but per the Fedora Packaging
> > Guidelines: "Use of macros and conditionals
> >    for other distributions, including Fedora derivatives, is not
> >    permitted in spec files of packages in the main Fedora repositories."
> >    I am assuming this shouldn't be here, but if I'm wrong please let me know
> > why.
> 
> Hi Kurtis, where did you read this?
> I skimmed https://docs.fedoraproject.org/en-US/packaging-guidelines/ and
> didn't see it.
> 
> > Hi Jeremy, I read it under the "Spec Legibility" on https://docs.fedoraproject.org/en-US/packaging-guidelines/

Tom, the language seems a bit vague.

> Use of macros and conditionals for other distributions, including Fedora derivatives, is not permitted in spec
> files of packages in the main Fedora repositories unless those macros and conditionals are also present in Fedora

I guess technically the conditionals are also present in Fedora but not used?
The language is not very clear.

Thoughts?