Bug 245335

Summary: Wrong init script
Product: Red Hat Enterprise Linux 5 Reporter: Michal Marciniszyn <mmarcini>
Component: tog-pegasusAssignee: Vitezslav Crhonek <vcrhonek>
Status: CLOSED ERRATA QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 5.0CC: dkovalsk, tvujec
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2007-0522 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-11-07 16:48:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 237789, 245337, 245339    

Description Michal Marciniszyn 2007-06-22 14:41:14 UTC
Description of problem:
The tog-pegasus init script returns some incorrect error codes and some parts of
it prevent the correct status command call. 
if [ ! -x $CIMSERVER_BIN ]; then
    echo -n "tog-pegasus $1: $CIMSERVER_BIN not found or not executable.";
    failure;
    exit 1;
fi;
this code should appear in start function section (not before that, as it
prevents status command call) and could be more specific in error code (as 1 is
general error).
Same with this:
        echo "Usage: $0 {start|stop|status|restart|reload|force-reload|try-restart}"
        exit 1
core 3 would be more appropriate.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

This bug is tracked by 237789.

Comment 1 RHEL Program Management 2007-06-22 14:43:46 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 2 Radek Vokál 2007-07-12 10:49:47 UTC
The errata for 5.1 was already issued. This is low priority issue, thus dev_ack-
for now, feel free to move it to 5.2.

Comment 3 RHEL Program Management 2007-07-12 10:51:15 UTC
Development Management has reviewed and declined this request.  You may appeal
this decision by reopening this request. 

Comment 4 Radek Vokál 2007-07-17 08:13:21 UTC
Resurrection of devel_ack - we're doing another tog-paegasus respin, this one
will get in.

Comment 8 errata-xmlrpc 2007-11-07 16:48:12 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2007-0522.html